Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prettier by removing type imports #5

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

JackCA
Copy link
Contributor

@JackCA JackCA commented Jan 16, 2021

prettier 1.* does not support typescript 3.8's type imports so the following error would occur when prettier was run:

["ERROR" - 3:43:40 PM] '=' expected. (1:13)
> 1 | import type { Request, Response } from 'express';

This is also what's causing the current CI failure.

tsdx has not upgraded to prettier 2.* yet so we cannot use type imports yet.

See jaredpalmer/tsdx#632 and prettier/prettier#7263

This doesn't seem to have any impact on build size.

Since prettier works now, there are other prettier-related fixes in this PR.

- prettier 1.* does not support typescript 3.8's type imports. tsdx has
  not upgraded to prettier 2.* yet so we cannot use type imports yet.
  See jaredpalmer/tsdx#632 and prettier/prettier#7263
@mxstbr mxstbr merged commit bc1b356 into mxstbr:master Jan 16, 2021
@mxstbr
Copy link
Owner

mxstbr commented Jan 16, 2021

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants