fix prettier by removing type imports #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettier
1.*
does not support typescript 3.8's type imports so the following error would occur when prettier was run:This is also what's causing the current CI failure.
tsdx has not upgraded to prettier
2.*
yet so we cannot use type imports yet.See jaredpalmer/tsdx#632 and prettier/prettier#7263
This doesn't seem to have any impact on build size.
Since prettier works now, there are other prettier-related fixes in this PR.