(deps): upgrade several deps' majors; require Node 10+ #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2020
agilgur5
force-pushed
the
upgrade-node-10
branch
from
b25c2df
to
bede06a
Compare
agilgur5
commented
Apr 12, 2020
agilgur5
added
the
scope: dependencies
This was referenced Apr 21, 2020
agilgur5
force-pushed
the
upgrade-node-10
branch
from
bede06a
to
efa4129
Compare
- officially drop support for Node <10 since many deps don't support
it anymore
- it has been EoL since Dec 31, 2019 and many deps are using newer,
ES2017 language features now too
- previously we deprecated it and semi-officially dropped, this time
is fully official with engines requirement
- and makes `--target node` target Node v10 instead of v8
- and will be released as a breaking change
- camelcase, chalk, execa, and fs-extra all dropped Node <10
- so did prettier v2 and rollup v2 which we will update to in the
near future
- ora and rollup-plugin-sourcemaps dropped Node <8 in breaking bumps
- so could've upgraded before, but for some reason some past
Greenkeeper PRs were closed
- and pascal-case upgrade didn't change any Node version support
- Jest 25, which we will update to in the same breaking release, also
dropped support for Node <8
- rollup-plugin-sourcemaps v0.5 is now written in TS and ships its own
types, so no need for its @types/ counterpart anymore
- pascal-case changed to use named export instead of a default export
agilgur5
force-pushed
the
upgrade-node-10
branch
from
efa4129
to
bb392bd
Compare
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/ezzfl0hcs |
|
Rebased and tests still all pass, merging as getting ready to release v0.14.0 now that v0.13.3 has been released |
|
Checked what all the deprecation warnings on a fresh install of npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated // [email protected]
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated // [email protected] |
This was referenced Sep 21, 2020
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- officially drop support for Node <10 since many deps don't support
it anymore
- it has been EoL since Dec 31, 2019 and many deps are using newer,
ES2017 language features now too
- previously we deprecated it and semi-officially dropped, this time
is fully official with engines requirement
- and makes `--target node` target Node v10 instead of v8
- and will be released as a breaking change
- camelcase, chalk, execa, and fs-extra all dropped Node <10
- so did prettier v2 and rollup v2 which we will update to in the
near future
- ora and rollup-plugin-sourcemaps dropped Node <8 in breaking bumps
- so could've upgraded before, but for some reason some past
Greenkeeper PRs were closed
- and pascal-case upgrade didn't change any Node version support
- Jest 25, which we will update to in the same breaking release, also
dropped support for Node <8
- rollup-plugin-sourcemaps v0.5 is now written in TS and ships its own
types, so no need for its @types/ counterpart anymore
- pascal-case changed to use named export instead of a default export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
officially drop support for Node <10 since many deps don't support
it anymore
ES2017 language features now too
is fully official with engines requirement
camelcase, chalk, execa, and fs-extra all dropped Node <10
near future
ora and rollup-plugin-sourcemaps dropped Node <8 in breaking bumps
Greenkeeper PRs were closed
dropped support for Node <8
rollup-plugin-sourcemaps v0.5 is now written in TS and ships its own
types, so no need for its @types/ counterpart anymore
pascal-case changed to use named export instead of a default export
Node 10 bump
Officially drop Node 10 after deprecation in #426 and semi-official drop in #433 .
Also merges together a handful of Greenkeeper PRs that required Node 10+:
And now Prettier v2 (#632) and Rollup v2 (#545) upgrades at least won't have to worry about this breakage (those do still have worry about other breakage still though 😅 )
Other dep upgrades
And some Greenkeeper PRs that were previously closed for unknown reasons but don't require Node 10+ ended up getting wrapped in here too (not intentionally, was just upgrading deps in general and looking for Node 10 requirements):
Based on #323 (comment), it seems like at the time Greenkeeper made an automated PR for a minor version for some reason and maybe these were mistaken for the same thing.
The CI failures fixed by #504 that made Greenkeeper open lots of issues around failing in-range updates may have also caused some other errors with Greenkeeper or confusion around it in general.
Should be good now, though not totally sure why
rollup-plugin-sourcemapsdoesn't seem to have a Greenkeeper PR for it.