-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use low priority validation for FieldArray #2707
Use low priority validation for FieldArray #2707
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/formik/9zse0b3iz |
Thanks @pietmichal - btw, we've been running this change as a patch in our application for about two weeks now and it's been working well so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the prop to unstable_validateFormWithLowPriority
as I don't think I want to fully document this yet?
@jaredpalmer For sure, will try to get to it soon. |
@maddhruv is attempting to deploy a commit to the Formium Team on Vercel. A member of the Team first needs to authorize it. |
@jaredpalmer It looks like this PR is no longer relevant as of #2891? Do you have any ideas on how to address performance concerns with |
Formik 3 alpha which I'm about to release in a few minutes |
Closing since this is no longer a valid strategy as of #2891 |
We've been experiencing issues with laggy text input fields in our application, specifically when using
FieldArray
, even on forms with a small number of fields (less than 10). UsingFastField
has been an acceptable workaround in certain cases but has its own drawbacks, so I tried out the suggestion in #2542 in our application and confirmed that using low priority validation does fix our performance issues (or is at least a very significant improvement).I don't believe this change affects the current API at all - it just exposes
validateFormWithLowPriority
so that it can be used in place ofvalidateForm
(alias ofvalidateFormWithHighPriority
) inFieldArray
. This appears to be working well in our application and I can't see any obvious drawbacks, but let me know if there are any issues with running the validation with low priority here.Thanks for taking a look!