Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use low priority validation for FieldArray #2707

Closed
wants to merge 7 commits into from
Closed

Use low priority validation for FieldArray #2707

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3495a25
Use low priority form validation for FieldArray
Aug 17, 2020
9330a31
Fix test failures due to validateFormWithLowPriority
Aug 17, 2020
3eff61d
Merge branch 'master' into field-array-low-priority-validation
jaredpalmer Oct 26, 2020
ea358b4
Merge branch 'master' into field-array-low-priority-validation
jaredpalmer Oct 27, 2020
83204f8
Merge branch 'master' into field-array-low-priority-validation
jaredpalmer Oct 27, 2020
7fb0ba3
Merge branch 'master' into field-array-low-priority-validation
jaredpalmer Oct 27, 2020
1c5cdf8
Merge branch 'master' into field-array-low-priority-validation
maddhruv Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/formik/src/FieldArray.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class FieldArrayInner<Values = {}> extends React.Component<
) &&
this.props.formik.validateOnChange
) {
this.props.formik.validateForm(this.props.formik.values);
this.props.formik.validateFormWithLowPriority(this.props.formik.values);
}
}

Expand Down
2 changes: 2 additions & 0 deletions packages/formik/src/Formik.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,7 @@ export function useFormik<Values extends FormikValues = FormikValues>({
resetForm,

validateForm: validateFormWithHighPriority,
validateFormWithLowPriority,
validateField,
setErrors,
setFieldError,
Expand Down Expand Up @@ -982,6 +983,7 @@ export function useFormik<Values extends FormikValues = FormikValues>({
setValues,
submitForm,
validateForm: validateFormWithHighPriority,
validateFormWithLowPriority,
validateField,
isValid,
dirty,
Expand Down
2 changes: 2 additions & 0 deletions packages/formik/src/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ export interface FormikHelpers<Values> {
) => void;
/** Validate form values */
validateForm: (values?: any) => Promise<FormikErrors<Values>>;
/** Validate form values w/o blocking UI */
validateFormWithLowPriority: (values?: any) => void;
/** Validate field value */
validateField: (field: string) => void;
/** Reset form */
Expand Down
2 changes: 2 additions & 0 deletions packages/formik/test/withFormik.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ describe('withFormik()', () => {
unregisterField: expect.any(Function),
validateField: expect.any(Function),
validateForm: expect.any(Function),
validateFormWithLowPriority: expect.any(Function),
validateOnBlur: true,
validateOnMount: false,
validateOnChange: true,
Expand Down Expand Up @@ -184,6 +185,7 @@ describe('withFormik()', () => {
setValues: expect.any(Function),
validateField: expect.any(Function),
validateForm: expect.any(Function),
validateFormWithLowPriority: expect.any(Function),
submitForm: expect.any(Function),
}
)
Expand Down