Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS configuration for Zipkin #3675

Closed
wants to merge 11 commits into from
Closed

TLS configuration for Zipkin #3675

wants to merge 11 commits into from

Conversation

mmorel-35
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add tls configuration for Zipkin server

Signed-off-by: Matthieu MOREL [email protected]

@mmorel-35 mmorel-35 requested a review from a team as a code owner May 13, 2022 10:11
@mmorel-35 mmorel-35 requested a review from vprithvi May 13, 2022 10:11
albertteoh and others added 11 commits May 13, 2022 12:15
* Add metrics instrumentation for SPM (MetricsReader)

Signed-off-by: Albert Teoh <[email protected]>

* Add metrics for all-in-one and new prometheus reader

Signed-off-by: Albert Teoh <[email protected]>

* Remove new prometheus metrics instrumentation

Signed-off-by: Albert Teoh <[email protected]>

* Add license

Signed-off-by: Albert Teoh <[email protected]>

* Revert unused metrics for prometheus factory

Signed-off-by: Albert Teoh <[email protected]>

* Long params to multiline and inline return

Signed-off-by: Albert Teoh <[email protected]>

* make fmt

Signed-off-by: Albert Teoh <[email protected]>

* Group logger and metrics next to each other

Signed-off-by: Albert Teoh <[email protected]>

* Remove copied comment

Signed-off-by: Albert Teoh <[email protected]>

* Remove responses metric

Signed-off-by: Albert Teoh <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1 to 2.
- [Release notes](https://github.com/docker/setup-qemu-action/releases)
- [Commits](docker/setup-qemu-action@v1...v2)

---
updated-dependencies:
- dependency-name: docker/setup-qemu-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <[email protected]>
* Sanitize spans with null process or empty service name

Signed-off-by: Yuri Shkuro <[email protected]>

* cleanup

Signed-off-by: Yuri Shkuro <[email protected]>

* review comments

Signed-off-by: Yuri Shkuro <[email protected]>

* wait longer

Signed-off-by: Yuri Shkuro <[email protected]>

* add tests

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
* Add kubernetes example for hotrod app

Signed-off-by: Brandon High <[email protected]>

* Remove grafana-agent optional configuration

Signed-off-by: Brandon High <[email protected]>

* Add redis container to kubernetes deployment example

Also reduces the cpu/memory limits as they were excessive initially.

Signed-off-by: Brandon High <[email protected]>

* Move kubernetes example into hotrod/kubernetes

Signed-off-by: Brandon High <[email protected]>

* Add jaeger all-in-one to kubernetes example

Signed-off-by: Brandon High <[email protected]>

* Add one-liner for port-forward to see traces

Signed-off-by: Brandon High <[email protected]>

* Tracing port needs to be UDP not TCP

Signed-off-by: Brandon High <[email protected]>

* Update examples/hotrod/README.md

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Brandon High <[email protected]>

* Move up kubernetes section in hotrod example README

Signed-off-by: Brandon High <[email protected]>

* Apply suggestions from code review

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Brandon High <[email protected]>

* Add cleanup to k8s example READMEs

Signed-off-by: Brandon High <[email protected]>

* Remove redis from hotrod example

Signed-off-by: Brandon High <[email protected]>

* Use pod local/localhost for jaeger-all-in-one

Signed-off-by: Brandon High <[email protected]>

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
* Flow tenant through processors as a string

Signed-off-by: Ed Snible <[email protected]>

* GetTenant()/WithTenant() functions

Signed-off-by: Ed Snible <[email protected]>

* Tests for WithTenant()/GetTenant()

Signed-off-by: Ed Snible <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Solving a lint generated issue
by discarding the return value of `s.logError`
fix [#3361]

Signed-off-by: Leonardo Zamariola <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 closed this May 13, 2022
@mmorel-35 mmorel-35 deleted the issue-3668-new branch May 13, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TLS config for Zipkin Collector
7 participants