Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes example for hotrod app #3645

Merged
merged 15 commits into from
May 10, 2022

Conversation

highb
Copy link
Contributor

@highb highb commented Apr 26, 2022

Which problem is this PR solving?

  • Provides an easy example for running the Jaeger all-in-one service and the hotrod app in any k8s cluster for demo and testing purposes.

Short description of the changes

  • Adds a kubernetes deployment example with configuration modes for Jaeger all-in-one and the hotrod app by itself. Can be used with kustomize out of the box or the manifests can be applied directly to your cluster.

@highb highb requested a review from a team as a code owner April 26, 2022 18:49
@highb highb requested a review from pavolloffay April 26, 2022 18:49
examples/kubernetes/README.md Outdated Show resolved Hide resolved
examples/hotrod/README.md Outdated Show resolved Hide resolved
examples/kubernetes/deployment.yaml Outdated Show resolved Hide resolved
examples/kubernetes/kustomization.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #3645 (323fe27) into main (7ad154e) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 323fe27 differs from pull request most recent head 5842ad9. Consider uploading reports for the commit 5842ad9 to get more accurate results

@@            Coverage Diff             @@
##             main    #3645      +/-   ##
==========================================
- Coverage   96.50%   96.42%   -0.09%     
==========================================
  Files         267      264       -3     
  Lines       15653    15509     -144     
==========================================
- Hits        15106    14954     -152     
- Misses        457      465       +8     
  Partials       90       90              
Impacted Files Coverage Δ
plugin/storage/grpc/shared/grpc_client.go 79.06% <0.00%> (-6.73%) ⬇️
plugin/storage/grpc/shared/grpc_server.go 74.28% <0.00%> (-1.88%) ⬇️
plugin/storage/grpc/factory.go 94.64% <0.00%> (-0.44%) ⬇️
plugin/storage/grpc/grpc.go 0.00% <0.00%> (ø)
cmd/collector/app/options.go 100.00% <0.00%> (ø)
cmd/query/app/static_handler.go 95.80% <0.00%> (ø)
cmd/collector/app/span_processor.go 100.00% <0.00%> (ø)
plugin/storage/grpc/memory/plugin.go 100.00% <0.00%> (ø)
plugin/storage/grpc/shared/plugin.go 0.00% <0.00%> (ø)
cmd/collector/app/sanitizer/sanitizer.go 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad154e...5842ad9. Read the comment docs.

examples/hotrod/README.md Outdated Show resolved Hide resolved
examples/hotrod/README.md Outdated Show resolved Hide resolved
examples/hotrod/kubernetes/base/hotrod/deployment.yaml Outdated Show resolved Hide resolved
examples/hotrod/README.md Outdated Show resolved Hide resolved
examples/hotrod/README.md Outdated Show resolved Hide resolved
examples/hotrod/README.md Show resolved Hide resolved
examples/hotrod/kubernetes/README.md Show resolved Hide resolved
examples/hotrod/kubernetes/base/hotrod/deployment.yaml Outdated Show resolved Hide resolved
highb and others added 13 commits April 26, 2022 16:57
Also reduces the cpu/memory limits as they were excessive initially.

Signed-off-by: Brandon High <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Brandon High <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Brandon High <[email protected]>
@yurishkuro
Copy link
Member

@joe-elliott I assume you work with k8s, can you give this one a spin to validate?

@yurishkuro yurishkuro merged commit 8fd5c0c into jaegertracing:main May 10, 2022
@yurishkuro
Copy link
Member

Thanks, @highb. If people find issues with these instructions, prepare to be tagged :-)

albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
* Add kubernetes example for hotrod app

Signed-off-by: Brandon High <[email protected]>

* Remove grafana-agent optional configuration

Signed-off-by: Brandon High <[email protected]>

* Add redis container to kubernetes deployment example

Also reduces the cpu/memory limits as they were excessive initially.

Signed-off-by: Brandon High <[email protected]>

* Move kubernetes example into hotrod/kubernetes

Signed-off-by: Brandon High <[email protected]>

* Add jaeger all-in-one to kubernetes example

Signed-off-by: Brandon High <[email protected]>

* Add one-liner for port-forward to see traces

Signed-off-by: Brandon High <[email protected]>

* Tracing port needs to be UDP not TCP

Signed-off-by: Brandon High <[email protected]>

* Update examples/hotrod/README.md

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Brandon High <[email protected]>

* Move up kubernetes section in hotrod example README

Signed-off-by: Brandon High <[email protected]>

* Apply suggestions from code review

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Brandon High <[email protected]>

* Add cleanup to k8s example READMEs

Signed-off-by: Brandon High <[email protected]>

* Remove redis from hotrod example

Signed-off-by: Brandon High <[email protected]>

* Use pod local/localhost for jaeger-all-in-one

Signed-off-by: Brandon High <[email protected]>

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Albert Teoh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants