TLS configuration for Zipkin

[mmorel-35]

Which problem is this PR solving?

• Fixes Support TLS config for Zipkin Collector #3668
• Replaces TLS configuration for Zipkin #3674
• Replaces TLS configuration for Zipkin #3675

Short description of the changes

• Add tls configuration for Zipkin server

Signed-off-by: Matthieu MOREL [email protected]

[codecov]

Codecov Report

Merging #3676 (439b600) into main (a49094c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3676      +/-   ##
==========================================
+ Coverage   96.50%   96.56%   +0.06%     
==========================================
  Files         268      268              
  Lines       15668    15689      +21     
==========================================
+ Hits        15120    15150      +30     
+ Misses        457      449       -8     
+ Partials       91       90       -1     

Impacted Files	Coverage Δ
ports/ports.go	100.00% <ø> (ø)
cmd/collector/app/builder_flags.go	100.00% <100.00%> (ø)
cmd/collector/app/collector.go	76.36% <100.00%> (+0.66%)	⬆️
cmd/collector/app/server/zipkin.go	92.45% <100.00%> (+21.72%)	⬆️
pkg/config/tlscfg/cert_watcher.go	92.63% <0.00%> (-2.11%)	⬇️
cmd/query/app/static_handler.go	95.80% <0.00%> (+1.79%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49094c...439b600. Read the comment docs.

[albertteoh]

How to update the documentation for example.

You shouldn't need to explicitly modify docs as the CLI docs are autogenerated on release: https://github.com/jaegertracing/documentation/blob/main/RELEASE.md#auto-generated-documentation-for-cli-flags

[mmorel-35]

You shouldn't need to explicitly modify docs as the CLI docs are autogenerated on release:

Oh, great 👍🏻 !!

[albertteoh]

Looks good, just a couple of nits.

[albertteoh]

Thanks!

[mmorel-35]

Hi @albertteoh , @yurishkuro !
When can we expect for the next release including the TLS features on Admin and Zipkin collector to be published ?

[albertteoh]

Hi @albertteoh , @yurishkuro ! When can we expect for the next release including the TLS features on Admin and Zipkin collector to be published ?

The tentative date for the next release v1.35.0 is around 3rd June: https://github.com/jaegertracing/jaeger/blob/main/RELEASE.md#release-managers

[mmorel-35]

Great! Thank you!