Skip to content

Revert "override BAZEL_ENVOY_PATH for local envoy tests (#2125)"#2128

Merged
istio-testing merged 1 commit intoistio:masterfrom
clarketm:revert-override-envoy-path
Nov 22, 2019
Merged

Revert "override BAZEL_ENVOY_PATH for local envoy tests (#2125)"#2128
istio-testing merged 1 commit intoistio:masterfrom
clarketm:revert-override-envoy-path

Conversation

@clarketm
Copy link
Member

@clarketm clarketm commented Nov 21, 2019

This reverts commit 1b088ea.

This workaround is no longer needed once since istio/proxy#2578 goes went through.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Nov 21, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 21, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2019
@clarketm clarketm marked this pull request as ready for review November 22, 2019 19:51
@clarketm clarketm requested a review from a team as a code owner November 22, 2019 19:51
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Nov 22, 2019
@istio-testing istio-testing merged commit 8497720 into istio:master Nov 22, 2019
@istio-testing
Copy link
Collaborator

@clarketm: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key istio-private.proxy.master.gen.yaml using file prow/cluster/jobs/istio-private/proxy/istio-private.proxy.master.gen.yaml
  • key istio-private.proxy.release-1.4.yaml using file prow/cluster/jobs/istio-private/proxy/istio-private.proxy.release-1.4.yaml
Details

In response to this:

This reverts commit 1b088ea.

This workaround is no longer needed once since istio/proxy#2578 goes went through.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants