Skip to content

Revert "override BAZEL_ENVOY_PATH for local envoy tests (#2125)" #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Nov 22, 2019
Merged

Revert "override BAZEL_ENVOY_PATH for local envoy tests (#2125)" #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions prow/cluster/jobs/istio-private/proxy/istio-private.proxy.master.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions prow/cluster/jobs/istio-private/proxy/istio-private.proxy.release-1.4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ presubmits:
env:
- name: BAZEL_BUILD_RBE_JOBS
value: "0"
- name: BAZEL_ENVOY_PATH
value: /home/prow/go/src/istio.io/proxy/bazel-bin/src/envoy/envoy
- name: ENVOY_PREFIX
value: envoy
- name: ENVOY_REPOSITORY
Expand Down Expand Up @@ -132,8 +130,6 @@ presubmits:
env:
- name: BAZEL_BUILD_RBE_JOBS
value: "0"
- name: BAZEL_ENVOY_PATH
value: /home/prow/go/src/istio.io/proxy/bazel-bin/src/envoy/envoy
- name: ENVOY_PREFIX
value: envoy
- name: ENVOY_REPOSITORY
Expand Down Expand Up @@ -179,8 +175,6 @@ presubmits:
env:
- name: BAZEL_BUILD_RBE_JOBS
value: "0"
- name: BAZEL_ENVOY_PATH
value: /home/prow/go/src/istio.io/proxy/bazel-bin/src/envoy/envoy
- name: ENVOY_PREFIX
value: envoy
- name: ENVOY_REPOSITORY
Expand Down Expand Up @@ -226,8 +220,6 @@ presubmits:
env:
- name: BAZEL_BUILD_RBE_JOBS
value: "0"
- name: BAZEL_ENVOY_PATH
value: /home/prow/go/src/istio.io/proxy/bazel-bin/src/envoy/envoy
- name: ENVOY_PREFIX
value: envoy
- name: ENVOY_REPOSITORY
Expand Down
4 changes: 2 additions & 2 deletions prow/genjobs/gen-private-jobs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ go run ./genjobs \
--modifier=master_priv \
--labels preset-enable-netrc=true \
--job-type presubmit \
--env BAZEL_ENVOY_PATH=/home/prow/go/src/istio.io/proxy/bazel-bin/src/envoy/envoy,BAZEL_BUILD_RBE_JOBS=0,ENVOY_REPOSITORY=https://github.com/envoyproxy/envoy-wasm,ENVOY_PREFIX=envoy-wasm \
--env BAZEL_BUILD_RBE_JOBS=0,ENVOY_REPOSITORY=https://github.com/envoyproxy/envoy-wasm,ENVOY_PREFIX=envoy-wasm \
--repo-whitelist proxy

# istio/proxy master build jobs(s) - postsubmit(s)
Expand All @@ -77,7 +77,7 @@ go run ./genjobs \
--modifier=release-1.4_priv \
--labels preset-enable-netrc=true \
--job-type presubmit \
--env BAZEL_ENVOY_PATH=/home/prow/go/src/istio.io/proxy/bazel-bin/src/envoy/envoy,BAZEL_BUILD_RBE_JOBS=0,ENVOY_REPOSITORY=https://github.com/istio-private/envoy,ENVOY_PREFIX=envoy \
--env BAZEL_BUILD_RBE_JOBS=0,ENVOY_REPOSITORY=https://github.com/istio-private/envoy,ENVOY_PREFIX=envoy \
--repo-whitelist proxy

# istio/proxy release-1.4 build jobs(s) - postsubmit(s)
Expand Down