fix bazel calls when using local envoy and --override_repository#2578
Merged
istio-testing merged 1 commit intoistio:masterfrom Nov 22, 2019
Merged
fix bazel calls when using local envoy and --override_repository#2578istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
clarketm
changed the title
Member
Author
|
The presubmit test failures are related to a change in an upstream dependency: envoyproxy/envoy#9072 that needs to be pulled/cherrypicked in. |
clarketm
force-pushed
the
fix-bazel-info
branch
from
e8acb6e to
4128efd
Compare
istio-testing
added
size/M
clarketm
force-pushed
the
fix-bazel-info
branch
2 times, most recently
from
518f0fc to
b2f230e
Compare
istio-testing
removed
the
do-not-merge/work-in-progress
clarketm
added
the
cherrypick/release-1.4
clarketm
force-pushed
the
fix-bazel-info
branch
from
b2f230e to
fcabc5d
Compare
howardjohn
approved these changes
Nov 21, 2019
bianpengyuan
approved these changes
Nov 21, 2019
Collaborator
|
In response to a cherrypick label: new pull request created: #2580 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For performing build/test operations with a local envoy source; one configured via the
--override_repositoryflag.Otherwise, bazel will emit errors like:
ERROR: An error occurred during the fetch of repository 'envoy'and
ERROR: no such package @envoy//...on
bazel infocalls (since the override flag is unknown to the command) which is problematic for some/mostmaketargets that need to be aware of the envoy binary or bazel output locations.cc @howardjohn @yxue