merge latest 1.1 to sds_api branch by quanjielin · Pull Request #2099 · istio/proxy

quanjielin · 2019-01-31T01:55:04Z

No description provided.

Signed-off-by: Kuat Yessenov <kuat@google.com>

update envoy

to include the SNI inspecting method, for using SNI in telemetry and policies Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>

…a38ad58121ba5aa5af51 Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>

…_3b05bffcbaedaf6d112ba38ad58121ba5aa5af51 update Envoy's SHA to latest, to implement SNI telemetry reports and policy checks

Signed-off-by: Kuat Yessenov <kuat@google.com>

…equested_server_name_attribute Add connection requested server name attribute to TCP read filter

…lter"

…equested_server_name_attribute Revert "Add connection requested server name attribute to TCP read filter"

* update envoy sha * library bug fixes * bug fix * lint fixes * lint fixes * lint fixes * test fixes

…nge (istio#2076) * rename rbac permissive related attributes key due to envoy recent change * rename

) * Replace this with members in capture list. * update * fix format

… lambda function. (istio#2083) * fix bug * introduce ControlData * fix format * update * fix format * Revise * Pass ControlDataSharedPtr into Control and hold ref * pass JwtAuthenticationConstSharedPtr into JwtAuthStore to hold ref * Revise

…stio#2082) * Update Envoy SHA to latest with protobuf.Any configs (release-1.1). For istio/istio#10993. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * review: don't open /dev/stdout in tests. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* use route directive regardless of rpc status Signed-off-by: Kuat Yessenov <kuat@google.com> * log response code Signed-off-by: Kuat Yessenov <kuat@google.com>

* Upgrade Envoy to b3be571 This updates Envoy SHA to b3be571. Signed-off-by: Venil Noronha <veniln@vmware.com> * Update tls_utility paths This updates the tls_utility library and include paths. Signed-off-by: Venil Noronha <veniln@vmware.com> * Fix http mixer filter This adds the encodeMetadata implementation to the http mixer filter to fix a build issue. Signed-off-by: Venil Noronha <veniln@vmware.com> * Fix sha256sum overwrite error This removes the ln command from the CircleCI configuration to fix a file overwrite error on macOS jobs. Signed-off-by: Venil Noronha <veniln@vmware.com>

sha256sum shouldn't be necessary, since we use gsha256sum on macOS. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* add mixer error details into metadata Signed-off-by: Lizan Zhou <lizan@tetrate.io> * format Signed-off-by: Lizan Zhou <lizan@tetrate.io> * review Signed-off-by: Lizan Zhou <lizan@tetrate.io> * comment Signed-off-by: Lizan Zhou <lizan@tetrate.io>

…stio#2097) * WIP * add local and override tests * revert attributes_builder * white list forward attributes * add tests with whitelist * fix builder test for white listed attributes

googlebot · 2019-01-31T01:59:25Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

…0130

JimmyCYJ · 2019-01-31T02:47:05Z

/lgtm

istio-testing · 2019-01-31T02:47:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JimmyCYJ, quanjielin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JimmyCYJ]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot · 2019-01-31T02:48:45Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

kyessenov and others added 30 commits July 3, 2018 12:56

update envoy

0646709

Signed-off-by: Kuat Yessenov <kuat@google.com>

Merge pull request istio#1838 from kyessenov/extra_field

5b05f36

update envoy

update Envoy's SHA to latest

0bfb526

to include the SNI inspecting method, for using SNI in telemetry and policies Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>

Merge branch 'release-1.0' into update_envoy_sha_3b05bffcbaedaf6d112b…

eb2afdd

…a38ad58121ba5aa5af51 Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>

Merge pull request istio#1839 from vadimeisenbergibm/update_envoy_sha…

09a0919

…_3b05bffcbaedaf6d112ba38ad58121ba5aa5af51 update Envoy's SHA to latest, to implement SNI telemetry reports and policy checks

implement destination.principal

f004f04

Signed-off-by: Kuat Yessenov <kuat@google.com>

missing test

0bbb1a0

Signed-off-by: Kuat Yessenov <kuat@google.com>

review

ff0bddd

Signed-off-by: Kuat Yessenov <kuat@google.com>

add AttributeName::kConnectionRequestedServerName

93e6641

fix format

777b38f

add GetRequestedServerName() to TCP CheckData

cb543c1

add building attribute ConnectionRequestedServerName

2ead919

test building attribute ConnectionRequestedServerName

b45b25d

add GetRequestedServerName() to tcp mixer filter

83dd6a0

fix compilation errors

0091e10

use explicit conversion from absl::string_view to std::string

79fa89f

check that the requested server name is not emtpy in attributes builder

336a0f0

fixed a compilation error

1389681

add GetRequestedServerName to http mixer filters (check_data)

a129dbf

add GetRequestedServerName to http MockCheckData

b1967a2

specify the class of a method

b874c59

add setting connection.requested_server_name to the http attributes

43e4bea

qualify Return by testing::

715ce48

use connection_ as a pointer

c3ab69c

add explicit conversion from absl::string_view to std::string

76fe1d8

add missing mock call

3da5327

Merge pull request istio#1843 from vadimeisenbergibm/add_connection_r…

1464e5e

…equested_server_name_attribute Add connection requested server name attribute to TCP read filter

Revert "Add connection requested server name attribute to TCP read fi…

4ea0ea0

…lter"

Merge pull request istio#1844 from istio/revert-1843-add_connection_r…

1a62f8b

…equested_server_name_attribute Revert "Add connection requested server name attribute to TCP read filter"

update the API SHA (istio/api#575)

4a02b92

GregHanson and others added 11 commits January 4, 2019 17:07

update envoy sha (istio#2074)

725d25e

* update envoy sha * library bug fixes * bug fix * lint fixes * lint fixes * lint fixes * test fixes

rename rbac permissive related attributes key due to envoy recent cha…

c98f781

…nge (istio#2076) * rename rbac permissive related attributes key due to envoy recent change * rename

Removes dangling pointer in capture list of lambda function. (istio#2080

702ee43

) * Replace this with members in capture list. * update * fix format

Update Istio API to latest (1.1 branch) (istio#2084)

cc6dc4a

Signed-off-by: Yangmin Zhu <ymzhu@google.com>

use route directive regardless of rpc status (istio#2087)

baf45ef

* use route directive regardless of rpc status Signed-off-by: Kuat Yessenov <kuat@google.com> * log response code Signed-off-by: Kuat Yessenov <kuat@google.com>

Fix build on macOS. (istio#2090) (istio#2094)

c8a1bf5

sha256sum shouldn't be necessary, since we use gsha256sum on macOS. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Forwarded attributes override statically configured Local Attributes (i…

b6b4b5d

…stio#2097) * WIP * add local and override tests * revert attributes_builder * white list forward attributes * add tests with whitelist * fix builder test for white listed attributes

istio-testing requested review from qiwzhang and rshriram January 31, 2019 01:55

googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jan 31, 2019

quanjielin force-pushed the quanlinmerge0130 branch 2 times, most recently from df00531 to cbf41ac Compare January 31, 2019 02:10

Merge remote-tracking branch 'upstream/release-1.1' into quanlinmerge…

6454835

…0130

quanjielin force-pushed the quanlinmerge0130 branch from cbf41ac to 6454835 Compare January 31, 2019 02:25

comment out failed test case

3940135

quanjielin removed the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jan 31, 2019

quanjielin assigned JimmyCYJ Jan 31, 2019

JimmyCYJ added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 31, 2019

istio-testing added the lgtm label Jan 31, 2019

istio-testing added the approved label Jan 31, 2019

istio-testing merged commit 169a4a5 into istio:sds_api Jan 31, 2019

quanjielin mentioned this pull request Jan 31, 2019

fix conflicted #2101

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge latest 1.1 to sds_api branch#2099

merge latest 1.1 to sds_api branch#2099
istio-testing merged 159 commits intoistio:sds_apifrom
quanjielin:quanlinmerge0130

quanjielin commented Jan 31, 2019

Uh oh!

googlebot commented Jan 31, 2019

Uh oh!

JimmyCYJ commented Jan 31, 2019

Uh oh!

istio-testing commented Jan 31, 2019

Uh oh!

googlebot commented Jan 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

quanjielin commented Jan 31, 2019

Uh oh!

googlebot commented Jan 31, 2019

Uh oh!

JimmyCYJ commented Jan 31, 2019

Uh oh!

istio-testing commented Jan 31, 2019

Uh oh!

googlebot commented Jan 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants