Conversation
googlebot
added
the
cla: yes
quanjielin
requested review from
JimmyCYJ
and removed request for
lizan and
rshriram
quanjielin
force-pushed
the
quanlinfix0131
branch
2 times, most recently
from
9cd15f4 to
b9028b6
Compare
quanjielin
force-pushed
the
quanlinfix0131
branch
from
b9028b6 to
c151fc2
Compare
| # | ||
| # Determine SHA256 `wget https://github.com/envoyproxy/envoy/archive/COMMIT.tar.gz && sha256sum COMMIT.tar.gz` | ||
| ENVOY_SHA = "b3be5713f2100ab5c40316e73ce34581245bd26a" | ||
| ENVOY_SHA256 = "79629284ae143d66b873c08883dc6382fac2e8ed45f6f3521f7e7282b6650216" |
There was a problem hiding this comment.
Don't remove sha256 here and below? You don't need to change this file actually
There was a problem hiding this comment.
This was comment out before but I accidentally revert it in #2099, I think the reason of removing sha256 in this repo because it's only for our testing(by updating the envoy_sha with a local build like https://github.com/istio/envoy/tree/sds_request_debug).
@JimmyCYJ could give more context.
There was a problem hiding this comment.
This sds_api branch was used to demo and test SDS when Envoy SDS work was under review. @quanjielin is going to use this branch for debugging and testing sds integration with istio.
There was a problem hiding this comment.
ah ok I thought this is release branch or master.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JimmyCYJ, quanjielin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
some unmerged from yesterday's #2099