update Envoy's SHA to latest, to implement SNI telemetry reports and policy checks #1839
update Envoy's SHA to latest, to implement SNI telemetry reports and policy checks #1839hklai merged 2 commits intoistio:release-1.0from vadimeisenbergibm:update_envoy_sha_3b05bffcbaedaf6d112ba38ad58121ba5aa5af51
Conversation
to include the SNI inspecting method, for using SNI in telemetry and policies Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
googlebot
added
the
cla: yes
|
@kyessenov Could you please merge this PR? |
|
All repositories are locked, and can only be merged by admins. I'm not an
admin.
…On Fri, Jul 6, 2018, 7:02 PM Vadim Eisenberg ***@***.***> wrote:
@vadimeisenbergibm <https://github.com/vadimeisenbergibm> requested your
review on: istio/proxy#1839 <#1839>
update Envoy's SHA to latest, to implement SNI telemetry reports and policy
checks .
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1839 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AJGIxkCFjNKrl2bBGMEOhx2p-EbfTsD1ks5uEBa2gaJpZM4VCKTo>
.
|
|
@hklai Could you please merge this PR? |
|
Please rebase to 1.0 ( I assume that's where you want it ) ? |
…a38ad58121ba5aa5af51 Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
|
@costinm Done. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JimmyCYJ, qiwzhang, vadimeisenbergibm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I don't think istio/istio#6810 is P0 for 1.0. should we even merge this at this point? |
|
@hklai I would really like to complete it this week. It is just one attribute to implement in istio-proxy, and it will upgrade egress traffic handling in Istio 1.0 significantly, since most of the egress traffic is TLS with SNI. |
|
@hklai Thanks, will do. |
8 participants
to include the SNI inspecting method, for using SNI in telemetry and
policies
Signed-off-by: Vadim Eisenberg vadime@il.ibm.com
What this PR does / why we need it:
The PR is a prerequisite for istio/istio#6810. It is required to extract SNI and to use it in telemetry reports and policy checks.
Which issue this PR fixes
A prerequisite for istio/istio#6810
Release note: