Rename "principals" to "names".#791
Conversation
Since this is defined under "subjects", we are basically referring to the "name" of a subject.
googlebot
added
the
cla: yes
liminw
requested review from
yangminzhu
and removed request for
andraxylia and
costinm
rbac/v1alpha1/rbac.proto
Outdated
| // `source.principal` attribute. If not specified, it applies to any principals. | ||
| repeated string principals = 4; | ||
| // Optional. A list of subject names. This is matched to the | ||
| // `source.principal` attribute. If one of subject names is "*", it matches any subject. |
There was a problem hiding this comment.
If one of subject names is "*", it matches any subject.
I find this a little confusing, does the second subject refer to the whole subject message (including other fields)? Or does it mean only the names field in the subject?
There was a problem hiding this comment.
It only applies to the "names" field in the subject. Other conditions for the subject still needs to be evaluated.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liminw, yangminzhu If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6 participants
Since this is defined under "subjects", we are basically referring to
the "name" of a subject.