add server_name to mixer remote handler tls / mtls#789
add server_name to mixer remote handler tls / mtls#789rshriram merged 2 commits intoistio:release-1.1from
Conversation
googlebot
added
the
cla: yes
|
/lgtm |
|
@kyessenov: changing LGTM is restricted to assignees, and assigning you to the PR failed. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bianpengyuan, kyessenov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@geeknoid Would you mind to help to merge this? Thank you so much! |
| string custom_header = 5; | ||
| } | ||
|
|
||
| // Indicates the name of adapter backend which is useful for routing with |
There was a problem hiding this comment.
This comment is extremely hard to understand, please reword.
There was a problem hiding this comment.
This is for hostname verification during X509 verification of a remote host? If so please document this
There was a problem hiding this comment.
Sorry for the confusing comment! This is to config server name for mixer's TLS client, for x509 hostname verification and virtual host routing, I will update the comment in another PR. Thanks!
7 participants
Address https://github.com/istio/istio/pull/10622/files#r255178977
Issue: istio/istio#7637
cc @kyessenov @mandarjog