Skip to content

Fix some typos in comment#763

Merged
wenchenglu merged 1 commit intoistio:release-1.1from
JoeWrightss:patch-3
Jan 25, 2019
Merged

Fix some typos in comment#763
wenchenglu merged 1 commit intoistio:release-1.1from
JoeWrightss:patch-3

Conversation

@JoeWrightss
Copy link
Copy Markdown
Contributor

@JoeWrightss JoeWrightss commented Jan 17, 2019

  1. "individial" to "individual".
  2. "estabilshes" to "establishes".

@JoeWrightss
Fix some typos in comment
dbc03a7 
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 17, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 17, 2019

Hi @JoeWrightss. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoeWrightss JoeWrightss deleted the patch-3 branch January 17, 2019 12:28
@JoeWrightss JoeWrightss changed the base branch from master to release-1.1 January 17, 2019 12:29
@JoeWrightss JoeWrightss restored the patch-3 branch January 17, 2019 12:30
@JoeWrightss JoeWrightss reopened this Jan 17, 2019
@JoeWrightss
Copy link
Copy Markdown
Contributor Author

JoeWrightss commented Jan 17, 2019

/assign @diemtvu

@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Jan 23, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 23, 2019
@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Jan 23, 2019

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoeWrightss, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Jan 25, 2019

@wenchenglu This is a benign change that fixes documentation. We should get this in for 1.1

@wenchenglu wenchenglu merged commit cd33a9a into istio:release-1.1 Jan 25, 2019
rshriram added a commit that referenced this pull request Jan 29, 2019
@rshriram
Revert "Fix some typos in comment (#763)"
934e7ab 
This reverts commit cd33a9a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandarjog mandarjog Awaiting requested review from mandarjog

@ozevren ozevren Awaiting requested review from ozevren

Assignees

@ozevren ozevren

@diemtvu diemtvu

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. review/done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JoeWrightss @istio-testing @ozevren @googlebot @wenchenglu @diemtvu