Deprecate defaultRevision value#760
Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom Apr 9, 2025
Merged
Conversation
This field shouldn't have been included in the IstioRevision.spec.values. It is a single global value that is not tied to any specific revision. The current plan is to make the default revision configurable elsewhere, possibly through a global singleton CRD called IstioBase. Signed-off-by: Marko Lukša <mluksa@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
+ Coverage 75.80% 75.87% +0.07%
==========================================
Files 44 44
Lines 2620 2620
==========================================
+ Hits 1986 1988 +2
+ Misses 543 542 -1
+ Partials 91 90 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgn
approved these changes
Apr 9, 2025
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Apr 9, 2025
* upstream/main: Add unit tests for revision.ListOwned and revision.isOwnedRevision (openshift-service-mesh#758) Add unit tests for GetReferencedRevisionFromNamespace, GetReferencedRevisionFromPod, and GetInjectedRevisionFromPod (openshift-service-mesh#756) Deprecate defaultRevision value (openshift-service-mesh#760)
Merged
6 tasks
dgn
pushed a commit
to dgn/sail-operator
that referenced
this pull request
Mar 17, 2026
This field shouldn't have been included in the IstioRevision.spec.values. It is a single global value that is not tied to any specific revision. The current plan is to make the default revision configurable elsewhere, possibly through a global singleton CRD called IstioBase. Signed-off-by: Marko Lukša <mluksa@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This field shouldn't have been included in the IstioRevision.spec.values. It is a single global value that is not tied to any specific revision. The current plan is to make the default revision configurable elsewhere, possibly through a global singleton CRD called IstioBase.