Skip to content

Deprecate defaultRevision value #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Apr 9, 2025
Merged

Deprecate defaultRevision value #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/v1/values_types.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion bundle/manifests/sailoperator.io_istiorevisions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ spec:
be configured with the same defaults as the specified version.
type: string
defaultRevision:
description: The name of the default revision in the cluster.
description: |-
The name of the default revision in the cluster.
Deprecated: This field is ignored. The default revision is expected to be configurable elsewhere.
type: string
experimental:
description: Specifies experimental helm fields that could be
Expand Down
4 changes: 3 additions & 1 deletion bundle/manifests/sailoperator.io_istios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ spec:
be configured with the same defaults as the specified version.
type: string
defaultRevision:
description: The name of the default revision in the cluster.
description: |-
The name of the default revision in the cluster.
Deprecated: This field is ignored. The default revision is expected to be configurable elsewhere.
type: string
experimental:
description: Specifies experimental helm fields that could be
Expand Down
4 changes: 3 additions & 1 deletion chart/crds/sailoperator.io_istiorevisions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ spec:
be configured with the same defaults as the specified version.
type: string
defaultRevision:
description: The name of the default revision in the cluster.
description: |-
The name of the default revision in the cluster.
Deprecated: This field is ignored. The default revision is expected to be configurable elsewhere.
type: string
experimental:
description: Specifies experimental helm fields that could be
Expand Down
4 changes: 3 additions & 1 deletion chart/crds/sailoperator.io_istios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ spec:
be configured with the same defaults as the specified version.
type: string
defaultRevision:
description: The name of the default revision in the cluster.
description: |-
The name of the default revision in the cluster.
Deprecated: This field is ignored. The default revision is expected to be configurable elsewhere.
type: string
experimental:
description: Specifies experimental helm fields that could be
Expand Down
1 change: 0 additions & 1 deletion docs/api-reference/sailoperator.io.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3117,7 +3117,6 @@ _Appears in:_
| `meshConfig` _[MeshConfig](#meshconfig)_ | Defines runtime configuration of components, including Istiod and istio-agent behavior. See https://istio.io/docs/reference/config/istio.mesh.v1alpha1/ for all available options. TODO can this import the real mesh config API? | | |
| `base` _[BaseConfig](#baseconfig)_ | Configuration for the base component. | | |
| `istiodRemote` _[IstiodRemoteConfig](#istiodremoteconfig)_ | Configuration for istiod-remote. DEPRECATED - istiod-remote chart is removed and replaced with `istio-discovery --set values.istiodRemote.enabled=true` Deprecated: Marked as deprecated in pkg/apis/values_types.proto. | | |
| `defaultRevision` _string_ | The name of the default revision in the cluster. | | |
| `profile` _string_ | Specifies which installation configuration profile to apply. | | |
| `compatibilityVersion` _string_ | Specifies the compatibility version to use. When this is set, the control plane will be configured with the same defaults as the specified version. | | |
| `experimental` _[RawMessage](#rawmessage)_ | Specifies experimental helm fields that could be removed or changed in the future | | Schemaless: \{\} |
Expand Down
3 changes: 3 additions & 0 deletions hack/api_transformer/transform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ inputFiles:
Values.Experimental:
- "// +kubebuilder:pruning:PreserveUnknownFields"
- "// +kubebuilder:validation:Schemaless"
Values.DefaultRevision:
- "// +hidefromdoc"
- "// Deprecated: This field is ignored. The default revision is expected to be configurable elsewhere."

- module: istio.io/api
path: /mesh/v1alpha1/config.pb.go
Expand Down