istio: ignore defaultRevision#1178
Merged
istio-testing merged 4 commits intoistio-ecosystem:mainfrom Oct 9, 2025
Merged
Conversation
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
+ Coverage 77.42% 77.71% +0.29%
==========================================
Files 44 44
Lines 2817 2827 +10
==========================================
+ Hits 2181 2197 +16
+ Misses 528 523 -5
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Collaborator
|
@jewertow Do you think this should be backported to release-1.26? |
Contributor
Author
|
Hey @FilipB, I think it should not be backported to any Z-stream release. It's a fairly significant change. |
Collaborator
|
could you extend the tests to verify that when creating an IstioRevisionTag called |
Collaborator
Nevermind, did it myself :) |
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
dgn
force-pushed
the
ignore-default-revision
branch
from
4d61f9e to
afa62af
Compare
dgn
approved these changes
Oct 9, 2025
Collaborator
|
/retest |
dgn
added a commit
to dgn/sail-operator
that referenced
this pull request
Mar 17, 2026
* istio: ignore `defaultRevision` Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com> * Fix failing tests Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com> * Fix lint error Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com> * test: check for presence of default validator Signed-off-by: Daniel Grimm <dgrimm@redhat.com> --------- Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Istio resource includes the
defaultRevisionfield which is used for controlling creation of the default validation webhook, which belongs to the base chart. Since the base chart is intended for managing cluster-scoped objects, it shouldn't be exposed in the Istio resource, because different revisions or tenants can affect webhooks created by others.That field was deprecated in #760, hidden from documentation, but it wasn't actually ignored as a comment for that field says.
This may be potentially a breaking change for users who rely on the default revision webhook, so we may consider adding a CRD for managing cluster-scoped objects first.