Skip to content

[release-1.0] Disable imageDigest support in ztunnel controller #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 2 commits into from
Jan 30, 2025
Merged

[release-1.0] Disable imageDigest support in ztunnel controller #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4101bb
Disable imageDigest support in ztunnel controller
sridhargaddam Jan 23, 2025
7ff1bd0
Use t.Skip() instead of Pending
sridhargaddam Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion controllers/ztunnel/ztunnel_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,16 @@ func (r *Reconciler) installHelmChart(ctx context.Context, ztunnel *v1alpha1.ZTu
userValues := ztunnel.Spec.Values

// apply image digests from configuration, if not already set by user
userValues = applyImageDigests(ztunnel, userValues, config.Config)
// TODO: Revisit once we support ImageOverrides for ztunnel
// userValues = applyImageDigests(ztunnel, userValues, config.Config)

if userValues == nil {
userValues = &v1.ZTunnelValues{}
}

if userValues.ZTunnel == nil {
userValues.ZTunnel = &v1.ZTunnelConfig{}
}

// apply userValues on top of defaultValues from profiles
mergedHelmValues, err := istiovalues.ApplyProfilesAndPlatform(
Expand Down
2 changes: 2 additions & 0 deletions controllers/ztunnel/ztunnel_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,8 @@ func TestDetermineReadyCondition(t *testing.T) {
}

func TestApplyImageDigests(t *testing.T) {
t.Skip("https://github.com/istio-ecosystem/sail-operator/issues/581")

testCases := []struct {
name string
config config.OperatorConfig
Expand Down