Skip to content

[release-1.28] fix: make pod readiness check more reliable after restart#1818

Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
istio-testing:cherry-pick-1815-to-release-1.28
Apr 14, 2026
Merged

[release-1.28] fix: make pod readiness check more reliable after restart#1818
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
istio-testing:cherry-pick-1815-to-release-1.28

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

@istio-testing istio-testing commented Apr 10, 2026

This is an automated cherry-pick of #1815

@sridhargaddam @istio-testing
fix: make pod readiness check more reliable after restart
da68c79 
The e2e test was re-listing pods immediately after deletion and waiting
on specific pod names, which made it prone to race conditions. It could
end up waiting on terminating pods which will never reach ready state.
This PR modifies the code to use Eventually to fix the issue.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@istio-testing istio-testing requested a review from a team as a code owner April 10, 2026 13:57
@istio-testing istio-testing mentioned this pull request Apr 10, 2026
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.62%. Comparing base (2430792) to head (da68c79).
⚠️ Report is 2 commits behind head on release-1.28.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.28    #1818      +/-   ##
================================================
+ Coverage         80.16%   80.62%   +0.46%     
================================================
  Files                46       46              
  Lines              2364     2364              
================================================
+ Hits               1895     1906      +11     
+ Misses              345      338       -7     
+ Partials            124      120       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@istio-testing istio-testing merged commit 6c07f6e into istio-ecosystem:release-1.28 Apr 14, 2026
19 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 14, 2026
Automated merge
60d4be3 
* upstream/release-1.28:
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 14, 2026
Automated merge
77d8cbd 
* upstream/release-1.28:
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 15, 2026
Automated merge
361fdc9 
* upstream/release-1.28:
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 15, 2026
Automated merge
be36813 
* upstream/release-1.28:
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 15, 2026
Automated merge
8b97304 
* upstream/release-1.28:
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 15, 2026
Automated merge
e5c5975 
* upstream/release-1.28:
  Pin sample apps to the release-x.y istio branch (istio-ecosystem#1834)
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 15, 2026
Automated merge
99b0c4d 
* upstream/release-1.28:
  [release-1.28] Improve testing images tags for OLM and Operator images (istio-ecosystem#1823)
  [release-1.28] Add 1.28.6 1.27.9 istio version (istio-ecosystem#1827)
  Pin sample apps to the release-x.y istio branch (istio-ecosystem#1834)
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 15, 2026
Automated merge
1198fc7 
* upstream/release-1.28:
  [release-1.28] Improve testing images tags for OLM and Operator images (istio-ecosystem#1823)
  [release-1.28] Add 1.28.6 1.27.9 istio version (istio-ecosystem#1827)
  Pin sample apps to the release-x.y istio branch (istio-ecosystem#1834)
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 16, 2026
Automated merge
ed2396e 
* upstream/release-1.28:
  [release-1.28] Improve testing images tags for OLM and Operator images (istio-ecosystem#1823)
  [release-1.28] Add 1.28.6 1.27.9 istio version (istio-ecosystem#1827)
  Pin sample apps to the release-x.y istio branch (istio-ecosystem#1834)
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 16, 2026
Automated merge
183a04a 
* upstream/release-1.28:
  [release-1.28] Improve testing images tags for OLM and Operator images (istio-ecosystem#1823)
  [release-1.28] Add 1.28.6 1.27.9 istio version (istio-ecosystem#1827)
  Pin sample apps to the release-x.y istio branch (istio-ecosystem#1834)
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 16, 2026
Automated merge
bb53f33 
* upstream/release-1.28:
  [release-1.28] Improve testing images tags for OLM and Operator images (istio-ecosystem#1823)
  [release-1.28] Add 1.28.6 1.27.9 istio version (istio-ecosystem#1827)
  Pin sample apps to the release-x.y istio branch (istio-ecosystem#1834)
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Apr 16, 2026
Automated merge
08a9ea5 
* upstream/release-1.28:
  Add missing cherry-picks for release-1.28 branch (istio-ecosystem#1842)
  [release-1.28] Improve testing images tags for OLM and Operator images (istio-ecosystem#1823)
  [release-1.28] Add 1.28.6 1.27.9 istio version (istio-ecosystem#1827)
  Pin sample apps to the release-x.y istio branch (istio-ecosystem#1834)
  fix: make pod readiness check more reliable after restart (istio-ecosystem#1818)
  fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816)
  Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810)
  [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773)
  [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801)
  Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sridhargaddam sridhargaddam sridhargaddam approved these changes

Assignees

No one assigned

Labels

release-notes-none size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@istio-testing @sridhargaddam