[release-1.28] Platform helm value is no longer used and needed + set OCP default value to false#1801
Merged
istio-testing merged 2 commits intoistio-ecosystem:release-1.28from Apr 7, 2026
Conversation
istio-testing
force-pushed
the
cherry-pick-1770-to-release-1.28
branch
2 times, most recently
from
d172204 to
d516f61
Compare
Platform value is not used anywhere as the automatic detection was introduced in istio-ecosystem#434 Signed-off-by: Filip Brychta <fbrychta@redhat.com>
We are running everything in kind in upstream so we need OCP to be set to false. We will need to set it to true in the midstream repo. Signed-off-by: Filip Brychta <fbrychta@redhat.com>
istio-testing
force-pushed
the
cherry-pick-1770-to-release-1.28
branch
from
d516f61 to
ae84b36
Compare
fjglira
approved these changes
Apr 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #1801 +/- ##
================================================
- Coverage 80.79% 80.41% -0.39%
================================================
Files 46 46
Lines 2364 2364
================================================
- Hits 1910 1901 -9
- Misses 336 342 +6
- Partials 118 121 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
istio-testing
merged commit f186e00
into
istio-ecosystem:release-1.28
18 of 19 checks passed
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 7, 2026
* upstream/release-1.28: [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 7, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 8, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 8, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 8, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 8, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 8, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 8, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 9, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 9, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 9, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-merge-bot bot
pushed a commit
to openshift-service-mesh/sail-operator
that referenced
this pull request
Apr 9, 2026
…ator@release-3.3#776 (#785) * Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791) * Add the possibility to override the test timeout Added DEFAULT_TEST_TIMEOUT to be able to override default 180 seconds timer across test suite Assisted-by: Cursor (claude-4.5-opus-high) * Added tests for TestGetInt Generated-by: Cursor (claude-4.5-opus-high) * Fix lint errors --------- Signed-off-by: mkralik3 <mkralik@redhat.com> * [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) * Platform helm value is no longer used and needed Platform value is not used anywhere as the automatic detection was introduced in istio-ecosystem#434 Signed-off-by: Filip Brychta <fbrychta@redhat.com> * Set default value for OCP to false We are running everything in kind in upstream so we need OCP to be set to false. We will need to set it to true in the midstream repo. Signed-off-by: Filip Brychta <fbrychta@redhat.com> --------- Signed-off-by: Filip Brychta <fbrychta@redhat.com> Co-authored-by: Filip Brychta <fbrychta@redhat.com> * [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) * Fix ztunnel version enumeration in update-version-list script (istio-ecosystem#1416) Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> * Regenerate catalog after ztunnel fix backported SSIA Signed-off-by: mkralik3 <mkralik@redhat.com> --------- Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: mkralik3 <mkralik@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> * Automated regeneration * Fix automerge --------- Signed-off-by: mkralik3 <mkralik@redhat.com> Signed-off-by: Filip Brychta <fbrychta@redhat.com> Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Co-authored-by: Istio Automation <istio-testing-bot@google.com> Co-authored-by: Filip Brychta <fbrychta@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Co-authored-by: openshift-service-mesh-bot <null>
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 9, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 9, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 9, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 10, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 10, 2026
* upstream/release-1.28: [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 10, 2026
* upstream/release-1.28: Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 10, 2026
* upstream/release-1.28: Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 10, 2026
* upstream/release-1.28: fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816) Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 10, 2026
* upstream/release-1.28: fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816) Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 13, 2026
* upstream/release-1.28: fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816) Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 13, 2026
* upstream/release-1.28: fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816) Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 13, 2026
* upstream/release-1.28: fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816) Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 13, 2026
* upstream/release-1.28: fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816) Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 13, 2026
* upstream/release-1.28: fix: use operator name as prefix in metrics-reader clusterrole. (istio-ecosystem#1816) Automator: Update dependencies in istio-ecosystem/sail-operator@release-1.28 (istio-ecosystem#1810) [release-1.28] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1773) [release-1.28] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1801) Add the possibility to override the test timeout (istio-ecosystem#1788) (istio-ecosystem#1791)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1770