api: add ZTunnel v1 CRD version by dgn · Pull Request #1365 · istio-ecosystem/sail-operator

dgn · 2025-11-18T16:32:32Z

This adds the v1 CRD version of ZTunnel which we missed earlier. The only change is the removal of the profile field which had only a valid value of ambient which was set by default. I moved setting the profile to ambient into the controller code instead.

codecov · 2025-11-18T16:36:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.64%. Comparing base (d2cbd96) to head (8777b0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
+ Coverage   80.38%   80.64%   +0.26%     
==========================================
  Files          44       44              
  Lines        2299     2299              
==========================================
+ Hits         1848     1854       +6     
+ Misses        330      327       -3     
+ Partials      121      118       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dgn · 2025-11-18T16:48:03Z

/retest

dgn · 2025-11-19T10:10:50Z

/cherry-pick release-1.28

istio-testing · 2025-11-19T10:10:53Z

@dgn: once the present PR merges, I will cherry-pick it on top of release-1.28 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dgn · 2025-11-19T10:10:54Z

/cherry-pick release-1.27

istio-testing · 2025-11-19T10:10:57Z

@dgn: once the present PR merges, I will cherry-pick it on top of release-1.27 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

docs/api-reference/sailoperator.io.md

sridhargaddam

Thanks @dgn for working on it.

controllers/ztunnel/ztunnel_controller.go

tests/e2e/ambient/ambient_test.go

docs/common/istio-ambient-mode.adoc

controllers/ztunnel/ztunnel_controller.go

sridhargaddam · 2025-11-19T11:24:24Z

@dgn do we need a conversion webhook to handle automatic conversion between v1alpha1 and v1 versions?

dgn · 2025-11-19T12:25:56Z

@dgn do we need a conversion webhook to handle automatic conversion between v1alpha1 and v1 versions?

nope, not at this time, as they're identical. and as we're changing the storedversion to v1, we shouldn't have to in the future, either

mkolesnik · 2025-11-20T16:12:55Z

api/v1/ztunnel_types.go

+	// +operator-sdk:csv:customresourcedefinitions:type=spec,xDescriptors={"urn:alm:descriptor:com.tectonic.ui:hidden"}
+	// +kubebuilder:validation:Enum=ambient;default;demo;empty;external;openshift-ambient;openshift;preview;remote;stable
+	// +kubebuilder:default=ambient
+	Profile string `json:"profile,omitempty"`


Didn't we want to drop this, since it's always ambient?

let's keep it now-- there might be other profiles down the line

Can't we always add it later should we need to?
This seems like unnecessary "preparing for the future that may never come" to me, especially given that adding the field will not break the API.

you're right, it's our only chance at this point 🙂 I removed the field and updated the NOTE in the docs. PTAL

This adds the v1 CRD version of ZTunnel which we missed earlier. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

sridhargaddam

LGTM. Adding a /hold if @mkolesnik has any final comments.
Feel free to remove the hold if required.

mkolesnik

LGTM

This adds the v1 CRD version of ZTunnel which we missed earlier. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* upstream/release-1.27: api: add ZTunnel v1 CRD version (istio-ecosystem#1365) (istio-ecosystem#1385) [release-1.27] Enhance IstioRevision dependency check to include ztunnel status (istio-ecosystem#1383)

* upstream/main: (67 commits) Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386) api: add ZTunnel v1 CRD version (istio-ecosystem#1365) Automatic update for Istio versions in Docs (istio-ecosystem#1374) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376) fix: pin helm to v3 (istio-ecosystem#1375) Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351) Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368) Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346) fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357) Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347) Test External Control Plane on latest versions (istio-ecosystem#1352) Adding Istio 1.28.0 (istio-ecosystem#1344) Fix make gen errors when vendor folder is present (istio-ecosystem#1348) Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326) CI: validate only the first commit message from the PR (istio-ecosystem#1342) Enhance IstioRevision dependency check to include ztunnel status (istio-ecosystem#1334) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1343) Use openshift-service-mesh org for our fork of community-operators-prod (istio-ecosystem#1340) ...

* upstream/main: (68 commits) Adding debug information for sample applications (istio-ecosystem#1390) Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386) api: add ZTunnel v1 CRD version (istio-ecosystem#1365) Automatic update for Istio versions in Docs (istio-ecosystem#1374) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376) fix: pin helm to v3 (istio-ecosystem#1375) Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351) Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368) Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346) fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357) Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347) Test External Control Plane on latest versions (istio-ecosystem#1352) Adding Istio 1.28.0 (istio-ecosystem#1344) Fix make gen errors when vendor folder is present (istio-ecosystem#1348) Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326) CI: validate only the first commit message from the PR (istio-ecosystem#1342) Enhance IstioRevision dependency check to include ztunnel status (istio-ecosystem#1334) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1343) ...

* upstream/main: (69 commits) Update AGENTS.md and domain knowledge files (istio-ecosystem#1395) Adding debug information for sample applications (istio-ecosystem#1390) Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386) api: add ZTunnel v1 CRD version (istio-ecosystem#1365) Automatic update for Istio versions in Docs (istio-ecosystem#1374) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376) fix: pin helm to v3 (istio-ecosystem#1375) Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351) Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368) Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346) fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357) Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347) Test External Control Plane on latest versions (istio-ecosystem#1352) Adding Istio 1.28.0 (istio-ecosystem#1344) Fix make gen errors when vendor folder is present (istio-ecosystem#1348) Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326) CI: validate only the first commit message from the PR (istio-ecosystem#1342) Enhance IstioRevision dependency check to include ztunnel status (istio-ecosystem#1334) ...

* upstream/main: (70 commits) Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402) Update AGENTS.md and domain knowledge files (istio-ecosystem#1395) Adding debug information for sample applications (istio-ecosystem#1390) Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386) api: add ZTunnel v1 CRD version (istio-ecosystem#1365) Automatic update for Istio versions in Docs (istio-ecosystem#1374) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376) fix: pin helm to v3 (istio-ecosystem#1375) Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351) Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368) Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346) fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357) Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347) Test External Control Plane on latest versions (istio-ecosystem#1352) Adding Istio 1.28.0 (istio-ecosystem#1344) Fix make gen errors when vendor folder is present (istio-ecosystem#1348) Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326) CI: validate only the first commit message from the PR (istio-ecosystem#1342) ...

* upstream/main: (71 commits) Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404) Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402) Update AGENTS.md and domain knowledge files (istio-ecosystem#1395) Adding debug information for sample applications (istio-ecosystem#1390) Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386) api: add ZTunnel v1 CRD version (istio-ecosystem#1365) Automatic update for Istio versions in Docs (istio-ecosystem#1374) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376) fix: pin helm to v3 (istio-ecosystem#1375) Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351) Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368) Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346) fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357) Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347) Test External Control Plane on latest versions (istio-ecosystem#1352) Adding Istio 1.28.0 (istio-ecosystem#1344) Fix make gen errors when vendor folder is present (istio-ecosystem#1348) Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326) ...

* upstream/main: (72 commits) Adding make target to run update-dependencies script (istio-ecosystem#1405) Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404) Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402) Update AGENTS.md and domain knowledge files (istio-ecosystem#1395) Adding debug information for sample applications (istio-ecosystem#1390) Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386) api: add ZTunnel v1 CRD version (istio-ecosystem#1365) Automatic update for Istio versions in Docs (istio-ecosystem#1374) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376) fix: pin helm to v3 (istio-ecosystem#1375) Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351) Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368) Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346) fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357) Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347) Test External Control Plane on latest versions (istio-ecosystem#1352) Adding Istio 1.28.0 (istio-ecosystem#1344) Fix make gen errors when vendor folder is present (istio-ecosystem#1348) ...

…tio-ecosystem#1365) (istio-ecosystem#1384) * api: add ZTunnel v1 CRD version (istio-ecosystem#1365) This adds the v1 CRD version of ZTunnel which we missed earlier. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Run make gen Run make gen to update the CRD and CSV Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Rafael Zago <rafaelvzago@gmail.com>

This adds the v1 CRD version of ZTunnel which we missed earlier. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

dgn requested a review from a team as a code owner November 18, 2025 16:32

istio-testing added the size/XXL label Nov 18, 2025

dgn force-pushed the bump-ztunnel branch 2 times, most recently from 2d1639c to 621a4c8 Compare November 18, 2025 16:44

dgn force-pushed the bump-ztunnel branch from 621a4c8 to 70102e0 Compare November 19, 2025 10:19

bmangoen reviewed Nov 19, 2025

View reviewed changes

docs/api-reference/sailoperator.io.md Show resolved Hide resolved

sridhargaddam reviewed Nov 19, 2025

View reviewed changes

controllers/ztunnel/ztunnel_controller.go Outdated Show resolved Hide resolved

tests/e2e/ambient/ambient_test.go Show resolved Hide resolved

docs/common/istio-ambient-mode.adoc Show resolved Hide resolved

controllers/ztunnel/ztunnel_controller.go Outdated Show resolved Hide resolved

dgn force-pushed the bump-ztunnel branch 2 times, most recently from 34198ec to f99a91e Compare November 19, 2025 12:31

mkolesnik reviewed Nov 20, 2025

View reviewed changes

istio-testing added the needs-rebase label Nov 21, 2025

dgn force-pushed the bump-ztunnel branch 2 times, most recently from f4710c7 to 8f8ce4e Compare November 24, 2025 15:43

istio-testing removed the needs-rebase label Nov 24, 2025

dgn force-pushed the bump-ztunnel branch 3 times, most recently from 12632c9 to 72f5e97 Compare November 24, 2025 16:38

api: add ZTunnel v1 CRD version

8777b0e

This adds the v1 CRD version of ZTunnel which we missed earlier. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

dgn force-pushed the bump-ztunnel branch from 72f5e97 to 8777b0e Compare November 24, 2025 16:58

sridhargaddam added the do-not-merge/hold label Nov 25, 2025

sridhargaddam approved these changes Nov 25, 2025

View reviewed changes

mkolesnik approved these changes Nov 25, 2025

View reviewed changes

istio-testing pushed a commit that referenced this pull request Nov 25, 2025

api: add ZTunnel v1 CRD version (#1365) (#1385)

f0ad4f1

This adds the v1 CRD version of ZTunnel which we missed earlier. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

dgn deleted the bump-ztunnel branch November 28, 2025 10:49

dgn added a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026

api: add ZTunnel v1 CRD version (istio-ecosystem#1365)

6b0ad97

This adds the v1 CRD version of ZTunnel which we missed earlier. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

Conversation

dgn commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dgn commented Nov 18, 2025

Uh oh!

dgn commented Nov 19, 2025

Uh oh!

istio-testing commented Nov 19, 2025

Uh oh!

dgn commented Nov 19, 2025

Uh oh!

istio-testing commented Nov 19, 2025

Uh oh!

Uh oh!

sridhargaddam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sridhargaddam commented Nov 19, 2025

Uh oh!

dgn commented Nov 19, 2025

Uh oh!

mkolesnik Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

dgn Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

mkolesnik Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

dgn Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

sridhargaddam left a comment

Choose a reason for hiding this comment

Uh oh!

mkolesnik left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dgn commented Nov 18, 2025 •

edited

Loading

codecov bot commented Nov 18, 2025 •

edited

Loading