Skip to content

Fix SIGPIPE error in update-istio-in-docs.sh script#1404

Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
fjglira:fix-update-job
Nov 27, 2025
Merged

Fix SIGPIPE error in update-istio-in-docs.sh script#1404
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
fjglira:fix-update-job

Conversation

@fjglira
Copy link
Copy Markdown
Contributor

@fjglira fjglira commented Nov 27, 2025

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

The script was failing in CI with exit code 141 due to SIGPIPE when using 'head -n 2' with 'set -o pipefail'. This temporarily disables pipefail around the problematic command to handle the SIGPIPE gracefully while maintaining script safety.

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR ##1403. I'll add the test in a separate PR

Additional information:

@fjglira
Fix SIGPIPE error in update-istio-in-docs.sh script
48d8dd1 
The script was failing in CI with exit code 141 due to SIGPIPE when using 'head -n 2' with 'set -o pipefail'. This temporarily disables pipefail around the problematic command to handle the SIGPIPE gracefully while maintaining script safety.

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
@fjglira fjglira requested a review from a team as a code owner November 27, 2025 16:17
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.12%. Comparing base (2cd754a) to head (48d8dd1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
+ Coverage   80.73%   81.12%   +0.39%     
==========================================
  Files          44       44              
  Lines        2299     2299              
==========================================
+ Hits         1856     1865       +9     
+ Misses        326      320       -6     
+ Partials      117      114       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dgn
dgn approved these changes Nov 27, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. you could also adjust the yq invocation to only returns first two items I guess, but not sure how hard/readable that is

@fjglira
Copy link
Copy Markdown
Contributor Author

fjglira commented Nov 27, 2025

/test e2e-kind-olm

@istio-testing istio-testing merged commit afdde80 into istio-ecosystem:main Nov 27, 2025
17 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 27, 2025
Automated merge
adaa38b 
* upstream/main: (71 commits)
  Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404)
  Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402)
  Update AGENTS.md and domain knowledge files (istio-ecosystem#1395)
  Adding debug information for sample applications (istio-ecosystem#1390)
  Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386)
  api: add ZTunnel v1 CRD version (istio-ecosystem#1365)
  Automatic update for Istio versions in Docs (istio-ecosystem#1374)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376)
  fix: pin helm to v3 (istio-ecosystem#1375)
  Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351)
  Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368)
  Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346)
  fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357)
  Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347)
  Test External Control Plane on latest versions (istio-ecosystem#1352)
  Adding Istio 1.28.0 (istio-ecosystem#1344)
  Fix make gen errors when vendor folder is present (istio-ecosystem#1348)
  Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 27, 2025
Automated merge
38e8d59 
* upstream/main: (71 commits)
  Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404)
  Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402)
  Update AGENTS.md and domain knowledge files (istio-ecosystem#1395)
  Adding debug information for sample applications (istio-ecosystem#1390)
  Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386)
  api: add ZTunnel v1 CRD version (istio-ecosystem#1365)
  Automatic update for Istio versions in Docs (istio-ecosystem#1374)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376)
  fix: pin helm to v3 (istio-ecosystem#1375)
  Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351)
  Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368)
  Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346)
  fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357)
  Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347)
  Test External Control Plane on latest versions (istio-ecosystem#1352)
  Adding Istio 1.28.0 (istio-ecosystem#1344)
  Fix make gen errors when vendor folder is present (istio-ecosystem#1348)
  Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 28, 2025
Automated merge
5b470be 
* upstream/main: (71 commits)
  Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404)
  Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402)
  Update AGENTS.md and domain knowledge files (istio-ecosystem#1395)
  Adding debug information for sample applications (istio-ecosystem#1390)
  Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386)
  api: add ZTunnel v1 CRD version (istio-ecosystem#1365)
  Automatic update for Istio versions in Docs (istio-ecosystem#1374)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376)
  fix: pin helm to v3 (istio-ecosystem#1375)
  Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351)
  Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368)
  Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346)
  fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357)
  Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347)
  Test External Control Plane on latest versions (istio-ecosystem#1352)
  Adding Istio 1.28.0 (istio-ecosystem#1344)
  Fix make gen errors when vendor folder is present (istio-ecosystem#1348)
  Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 28, 2025
Automated merge
a868b94 
* upstream/main: (71 commits)
  Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404)
  Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402)
  Update AGENTS.md and domain knowledge files (istio-ecosystem#1395)
  Adding debug information for sample applications (istio-ecosystem#1390)
  Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386)
  api: add ZTunnel v1 CRD version (istio-ecosystem#1365)
  Automatic update for Istio versions in Docs (istio-ecosystem#1374)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376)
  fix: pin helm to v3 (istio-ecosystem#1375)
  Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351)
  Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368)
  Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346)
  fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357)
  Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347)
  Test External Control Plane on latest versions (istio-ecosystem#1352)
  Adding Istio 1.28.0 (istio-ecosystem#1344)
  Fix make gen errors when vendor folder is present (istio-ecosystem#1348)
  Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 28, 2025
Automated merge
bc8a4cc 
* upstream/main: (71 commits)
  Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404)
  Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402)
  Update AGENTS.md and domain knowledge files (istio-ecosystem#1395)
  Adding debug information for sample applications (istio-ecosystem#1390)
  Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386)
  api: add ZTunnel v1 CRD version (istio-ecosystem#1365)
  Automatic update for Istio versions in Docs (istio-ecosystem#1374)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376)
  fix: pin helm to v3 (istio-ecosystem#1375)
  Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351)
  Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368)
  Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346)
  fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357)
  Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347)
  Test External Control Plane on latest versions (istio-ecosystem#1352)
  Adding Istio 1.28.0 (istio-ecosystem#1344)
  Fix make gen errors when vendor folder is present (istio-ecosystem#1348)
  Add Claude Code command for updating EOL Istio versions (istio-ecosystem#1326)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 28, 2025
Automated merge
eeb3c65 
* upstream/main: (72 commits)
  Adding make target to run update-dependencies script (istio-ecosystem#1405)
  Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404)
  Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402)
  Update AGENTS.md and domain knowledge files (istio-ecosystem#1395)
  Adding debug information for sample applications (istio-ecosystem#1390)
  Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386)
  api: add ZTunnel v1 CRD version (istio-ecosystem#1365)
  Automatic update for Istio versions in Docs (istio-ecosystem#1374)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376)
  fix: pin helm to v3 (istio-ecosystem#1375)
  Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351)
  Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368)
  Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346)
  fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357)
  Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347)
  Test External Control Plane on latest versions (istio-ecosystem#1352)
  Adding Istio 1.28.0 (istio-ecosystem#1344)
  Fix make gen errors when vendor folder is present (istio-ecosystem#1348)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 28, 2025
Automated merge
cb9fb2c 
* upstream/main: (72 commits)
  Adding make target to run update-dependencies script (istio-ecosystem#1405)
  Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#1404)
  Add CLAUDE.md to the sail operator repo (istio-ecosystem#1402)
  Update AGENTS.md and domain knowledge files (istio-ecosystem#1395)
  Adding debug information for sample applications (istio-ecosystem#1390)
  Remove Profile printcolumn from ztunnel status (istio-ecosystem#1386)
  api: add ZTunnel v1 CRD version (istio-ecosystem#1365)
  Automatic update for Istio versions in Docs (istio-ecosystem#1374)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1378)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1377)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1376)
  fix: pin helm to v3 (istio-ecosystem#1375)
  Make sure to skip cleanup of operator in e2e (istio-ecosystem#1351)
  Changes on crd-ref-docs templates to add API version to the CRD (istio-ecosystem#1368)
  Make getProxyVersion robust to changes in istioctl proxy-status format (istio-ecosystem#1346)
  fix: update codecov ignore pattern for tests directory (istio-ecosystem#1357)
  Unpining OLM version as 0.38.0 is reverting the breaking change (istio-ecosystem#1347)
  Test External Control Plane on latest versions (istio-ecosystem#1352)
  Adding Istio 1.28.0 (istio-ecosystem#1344)
  Fix make gen errors when vendor folder is present (istio-ecosystem#1348)
  ...
dgn pushed a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026
@fjglira @dgn
Fix SIGPIPE error in update-istio-in-docs.sh script (istio-ecosystem#…
9f4ea71 
…1404)

The script was failing in CI with exit code 141 due to SIGPIPE when using 'head -n 2' with 'set -o pipefail'. This temporarily disables pipefail around the problematic command to handle the SIGPIPE gracefully while maintaining script safety.

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgn dgn dgn approved these changes

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fjglira @dgn @istio-testing