Skip to content

[release-1.27] Enhance IstioRevision dependency check to include ztunnel status#1383

Merged
istio-testing merged 3 commits intoistio-ecosystem:release-1.27from
istio-testing:cherry-pick-1334-to-release-1.27
Nov 25, 2025
Merged

[release-1.27] Enhance IstioRevision dependency check to include ztunnel status#1383
istio-testing merged 3 commits intoistio-ecosystem:release-1.27from
istio-testing:cherry-pick-1334-to-release-1.27

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

This is an automated cherry-pick of #1334

The IstioRevision controller was missing health validation for
ZTunnel while using the ambient mode. Because of this, even when
ztunnel was missing/unhealthy, the IstioRevision was showing the
status as Ready. This PR fixes it.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
This commit includes changes in sailoperator.io.md file

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
This PR includes an integration test to validate the changes.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@istio-testing istio-testing force-pushed the cherry-pick-1334-to-release-1.27 branch from 71a5244 to a88217d Compare November 25, 2025 09:52
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (165b237) to head (a88217d).
⚠️ Report is 1 commits behind head on release-1.27.

Files with missing lines Patch % Lines
...trollers/istiorevision/istiorevision_controller.go 75.75% 7 Missing and 1 partial ⚠️
pkg/revision/dependency.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #1383      +/-   ##
================================================
+ Coverage         79.21%   80.88%   +1.66%     
================================================
  Files                44       44              
  Lines              2247     2291      +44     
================================================
+ Hits               1780     1853      +73     
+ Misses              362      321      -41     
- Partials            105      117      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@istio-testing istio-testing merged commit 82e3356 into istio-ecosystem:release-1.27 Nov 25, 2025
17 of 18 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 25, 2025
* upstream/release-1.27:
  api: add ZTunnel v1 CRD version (istio-ecosystem#1365) (istio-ecosystem#1385)
  [release-1.27] Enhance IstioRevision dependency check to include ztunnel status (istio-ecosystem#1383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants