fix: remove MeshConfig from ZTunnel CRD#1236
Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom Sep 26, 2025
Merged
fix: remove MeshConfig from ZTunnel CRD#1236istio-testing merged 1 commit intoistio-ecosystem:mainfrom
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
Conversation
This removes the MeshConfig field from the ZTunnel CRD, which was not operational anyway. Only one field from MeshConfig was ever used, defaultConfig.proxyMetadata, the content of which was written verbatim to the DaemonSet's environment variables. We'll be able to set this field automatically once we introduce `targetRef` support, and until then, should users require custom values, they can use `ztunnel.env` which has the same effect. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
26bfd9c to
cb36ce8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
+ Coverage 77.47% 77.50% +0.03%
==========================================
Files 44 44
Lines 2823 2823
==========================================
+ Hits 2187 2188 +1
Misses 527 527
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sridhargaddam
approved these changes
Sep 26, 2025
Collaborator
|
In response to a cherrypick label: #1236 failed to apply on top of branch "release-1.27": |
Collaborator
|
In response to a cherrypick label: new issue created for failed cherrypick: #1237 |
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Sep 26, 2025
* upstream/main: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) Fix broken link to docs/readme (istio-ecosystem#1231) Fix new lint errors (istio-ecosystem#1233)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Sep 29, 2025
* upstream/main: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) Fix broken link to docs/readme (istio-ecosystem#1231) Fix new lint errors (istio-ecosystem#1233)
dgn
added a commit
to dgn/sail-operator
that referenced
this pull request
Oct 2, 2025
This removes the MeshConfig field from the ZTunnel CRD, which was not operational anyway. Only one field from MeshConfig was ever used, defaultConfig.proxyMetadata, the content of which was written verbatim to the DaemonSet's environment variables. We'll be able to set this field automatically once we introduce `targetRef` support, and until then, should users require custom values, they can use `ztunnel.env` which has the same effect. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
istio-testing
pushed a commit
that referenced
this pull request
Oct 2, 2025
This removes the MeshConfig field from the ZTunnel CRD, which was not operational anyway. Only one field from MeshConfig was ever used, defaultConfig.proxyMetadata, the content of which was written verbatim to the DaemonSet's environment variables. We'll be able to set this field automatically once we introduce `targetRef` support, and until then, should users require custom values, they can use `ztunnel.env` which has the same effect. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 2, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 2, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 3, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 3, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 3, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 3, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 3, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 3, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 3, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 3, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: [release-1.27] fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1232) fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: [release-1.27] fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1232) fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: [release-1.27] fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1232) fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
dgn
added a commit
to dgn/sail-operator
that referenced
this pull request
Mar 17, 2026
This removes the MeshConfig field from the ZTunnel CRD, which was not operational anyway. Only one field from MeshConfig was ever used, defaultConfig.proxyMetadata, the content of which was written verbatim to the DaemonSet's environment variables. We'll be able to set this field automatically once we introduce `targetRef` support, and until then, should users require custom values, they can use `ztunnel.env` which has the same effect. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the MeshConfig field from the ZTunnel CRD, which was not operational anyway.
Only one field from MeshConfig was ever used, defaultConfig.proxyMetadata, the content
of which was written verbatim to the DaemonSet's environment variables. We'll be able to
set this field automatically once we introduce
targetRefsupport, and until then,should users require custom values, they can use
ztunnel.envwhich has the same effect.