Fix the unmatched request handling by set the grpc status in payload. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jianfei Hu <[email protected]>
Signed-off-by: Jianfei Hu <[email protected]>
Signed-off-by: Jianfei Hu <[email protected]>
incfly
requested review from
Shikugawa
and removed request for
BrenoDeMedeiros and
liminw
|
@dio @Shikugawa for review. |
Signed-off-by: Jianfei Hu <[email protected]>
lizan
reviewed
Jul 26, 2022
| @@ -12,6 +12,7 @@ | |||
| #include "common/config/version_converter.h" | |||
| #include "config/config.pb.h" | |||
| #include "envoy/common/exception.h" | |||
| // #include "envoy/grpc/status.h" | |||
Shikugawa
approved these changes
Jul 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incfly, Shikugawa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@incfly I observed a test failure in master... https://github.com/istio-ecosystem/authservice/runs/7541606968?check_suite_focus=true |
|
@Shikugawa suspect it's some build flakiness, rerunning, https://github.com/istio-ecosystem/authservice/runs/7545016277?check_suite_focus=true |
incfly
added a commit
that referenced
this pull request
Jul 28, 2022
…#223) * mst fix e2e with hardcode. Signed-off-by: Jianfei Hu <[email protected]> * wip organize the convert code. Signed-off-by: Jianfei Hu <[email protected]> * update example to use localhost Signed-off-by: Jianfei Hu <[email protected]> * make format. Signed-off-by: Jianfei Hu <[email protected]>
incfly
added a commit
to incfly/authservice
that referenced
this pull request
Jul 28, 2022
…istio-ecosystem#223) * mst fix e2e with hardcode. Signed-off-by: Jianfei Hu <[email protected]> * wip organize the convert code. Signed-off-by: Jianfei Hu <[email protected]> * update example to use localhost Signed-off-by: Jianfei Hu <[email protected]> * make format. Signed-off-by: Jianfei Hu <[email protected]>
incfly
added a commit
that referenced
this pull request
Jul 28, 2022
…#223) (#225) * mst fix e2e with hardcode. Signed-off-by: Jianfei Hu <[email protected]> * wip organize the convert code. Signed-off-by: Jianfei Hu <[email protected]> * update example to use localhost Signed-off-by: Jianfei Hu <[email protected]> * make format. Signed-off-by: Jianfei Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #140
Previously we only return the grpc status, but not set the actual response payload,
response.status.Verified works manually e2e with
allow_unmatched_request: true/falsehaving different effect.