Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal examples to make it easier to get started #252

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

nacx
Copy link
Collaborator

@nacx nacx commented Apr 18, 2024

The only configs we had are the e2e ones, but it may be hard to get there when you're just trying to get started.
Having a minimal set of configs that are easy to copy/paste will be very helpful.

@bburky
Copy link

bburky commented Apr 18, 2024

I would suggest including a RequestAuthentication and ALLOW AuthorizationPolicy which verify the JWT in the example config. Maybe include a comment to inform users that the CUSTOM AuthorizationPolicy runs first and these run afterwards.

Prior to #187 and #223, this was really the only way to deploy authservice safely: various requests would be allowed through authservice in undesired ways, mostly bypassing authentication. Having Istio perform JWT validation after authservice mitigated this and was the previous recommendation from the authservice developers: #140 (comment).

I think all of those old issues have been resolved now, and this would now just be extra defense in depth. (If the official recommendation has changed and Istio validation of the JWT is no longer considered required, some updated documentation would be appreciated.)

@nacx
Copy link
Collaborator Author

nacx commented Apr 18, 2024

Sounds good. I'll add those examples!

Signed-off-by: Ignasi Barrera <[email protected]>
@nacx
Copy link
Collaborator Author

nacx commented Apr 19, 2024

Done

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@1df3e7e). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage        ?   90.64%           
=======================================
  Files           ?       25           
  Lines           ?     1603           
  Branches        ?        0           
=======================================
  Hits            ?     1453           
  Misses          ?      107           
  Partials        ?       43           

Copy link
Collaborator

@sergicastro sergicastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nacx, sergicastro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit bdd1c3b into istio-ecosystem:main Apr 19, 2024
12 checks passed
@nacx nacx deleted the examples branch April 19, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants