feat(income-plan): Update updateValueObj in incomeType

[veronikasif]

[TS-913] Update updateValueObj in incomeType

What

Added application to valueModifier in TableRepeaterItem and updated updateValueObj in incomeType.

Why

incomeType is unset ('') when a row in income-plan table is edited. Should only be unset if incomeCategory is changed (incomeType does not match incomeCategory)

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Enhanced income type selection functionality with improved value handling.
  • Updated value modifier functions to utilize application context for better logic processing.

• Bug Fixes

  • Standardized parameter handling across various value modifier functions.

• Documentation

  • Updated function signatures to reflect new parameters and capabilities.

[coderabbitai]

Walkthrough

The changes involve modifications to the valueModifier functions in the IncomePlanForm.ts file, enhancing the handling of income-related fields. The valueModifier for the income type now accepts both application and activeField parameters, while other valueModifier functions have been standardized to use an underscore for the first parameter. Additionally, the valueModifier in the TableRepeaterItem structure has been updated to accept an application parameter, allowing for more complex logic. These adjustments improve the overall functionality and consistency of the form handling.

Changes

File	Change Summary
libs/application/templates/social-insurance-administration/income-plan/src/forms/IncomePlanForm.ts	Modified valueModifier functions to enhance functionality for income type and standardize parameters.
libs/application/types/src/lib/Fields.ts	Updated valueModifier signature to include application parameter, enhancing flexibility.
libs/application/ui-fields/src/lib/TableRepeaterFormField/TableRepeaterItem.tsx	Changed parameters in valueModifier call from one to two, adding application for improved context.

Possibly related PRs

• feat(income-plan): Incorrect monthly income when changing between montly and yearly income #15953: This PR modifies the IncomePlanForm.ts file, specifically the valueModifier function, which is directly related to the changes made in the main PR regarding the valueModifier functions in the same file.
• feat(income-plan): Don't allow negative numbers or 0 in income plan #15982: This PR also alters the dataSchema.ts file, which is relevant to the main PR's changes in the IncomePlanForm.ts and its handling of income-related validations.
• fix(income-plan): Hide IKR when foreign income #15987: This PR introduces new income types in the IncomePlanForm.ts, which aligns with the main PR's modifications to the valueModifier functions and their handling of income types.

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec97dd2 and 6946dfb.

Files selected for processing (3)

• libs/application/templates/social-insurance-administration/income-plan/src/forms/IncomePlanForm.ts (5 hunks)
• libs/application/types/src/lib/Fields.ts (1 hunks)
• libs/application/ui-fields/src/lib/TableRepeaterFormField/TableRepeaterItem.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (3)

• libs/application/templates/social-insurance-administration/income-plan/src/forms/IncomePlanForm.ts
• libs/application/types/src/lib/Fields.ts
• libs/application/ui-fields/src/lib/TableRepeaterFormField/TableRepeaterItem.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (8b22584) to head (6946dfb).

Files with missing lines	Patch %	Lines
...c/lib/TableRepeaterFormField/TableRepeaterItem.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15999   +/-   ##
=======================================
  Coverage   36.84%   36.84%           
=======================================
  Files        6718     6718           
  Lines      137733   137733           
  Branches    39159    39159           
=======================================
  Hits        50753    50753           
  Misses      86980    86980           

Flag	Coverage Δ
air-discount-scheme-web	0.00% <ø> (ø)
api	3.39% <ø> (ø)
application-api-files	57.46% <ø> (ø)
application-core	72.33% <ø> (ø)
application-system-api	41.67% <ø> (ø)
application-template-api-modules	23.47% <ø> (+0.01%)	⬆️
application-templates-accident-notification	22.26% <ø> (ø)
application-templates-car-recycling	3.12% <ø> (ø)
application-templates-criminal-record	26.96% <ø> (ø)
application-templates-driving-license	18.75% <ø> (ø)
application-templates-estate	12.55% <ø> (ø)
application-templates-example-payment	25.72% <ø> (ø)
application-templates-financial-aid	14.39% <ø> (ø)
application-templates-general-petition	23.95% <ø> (ø)
application-templates-health-insurance	26.88% <ø> (ø)
application-templates-inheritance-report	6.45% <ø> (ø)
application-templates-marriage-conditions	15.35% <ø> (ø)
application-templates-mortgage-certificate	44.15% <ø> (ø)
application-templates-parental-leave	29.31% <ø> (+0.11%)	⬆️
application-types	6.74% <ø> (ø)
application-ui-components	1.52% <ø> (ø)
application-ui-shell	21.74% <0.00%> (ø)
clients-charge-fjs-v2	24.11% <ø> (ø)
web	1.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
libs/application/types/src/lib/Fields.ts	100.00% <ø> (ø)
...c/lib/TableRepeaterFormField/TableRepeaterItem.tsx	2.15% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b22584...6946dfb. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 9fcbd6f 🔗

✅ 21 Total Test Services: 0 Failed, 21 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.24%), 1 increased (+0.1%), 88 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
air-discount-scheme-web	0	0	0	2	0	9.29s	1 no change	Link
api	0	0	0	4	0	3.08s	1 no change	Link
application-api-files	0	0	0	12	0	7.18s	1 no change	Link
application-core	0	0	0	90	0	21.54s	1 no change	Link
application-system-api	0	0	0	111	2	3m 42.27s	1 no change	Link
application-template-api-modules	0	0	0	109	0	1m 57.37s	1 no change	Link
application-templates-accident-notification	0	0	0	98	0	19.75s	1 no change	Link
application-templates-criminal-record	0	0	0	2	0	11.95s	1 no change	Link
application-templates-driving-license	0	0	0	13	0	17.38s	1 no change	Link
application-templates-example-payment	0	0	0	2	0	12.37s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (1)

• application-templates-social-insurance-administration-income-plan - jest 30.52% (-0.24%) - Details

[ylfahfa]

lgtm 😁