feat(income-plan): Don't allow negative numbers or 0 in income plan #15982
Conversation
WalkthroughThe changes made to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Application
participant Validator
User->>Application: Submit income data
Application->>Validator: Validate income fields
alt Income Type is YEARLY
Validator->>Validator: Check incomePerYear > 0
else Income Type is MONTHLY
Validator->>Validator: Check each month's income > 0
end
Validator-->>Application: Return validation results
Application-->>User: Display validation feedback
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/application/templates/social-insurance-administration/income-plan/src/lib/dataSchema.ts (5 hunks)
Additional context used
Path-based instructions (1)
libs/application/templates/social-insurance-administration/income-plan/src/lib/dataSchema.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (3)
libs/application/templates/social-insurance-administration/income-plan/src/lib/dataSchema.ts (3)
35-37: LGTM!The refinement logic correctly ensures that
incomePerYearis a positive value when theincomeisYEARLY.
57-58: LGTM!The refinement logic correctly ensures that
equalIncomePerMonthis a positive value under the specified conditions.
79-80: LGTM!The refinement logic correctly ensures that
equalForeignIncomePerMonthis a positive value under the specified conditions.
libs/application/templates/social-insurance-administration/income-plan/src/lib/dataSchema.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15982 +/- ##
==========================================
+ Coverage 36.84% 36.89% +0.04%
==========================================
Files 6718 6715 -3
Lines 137708 137538 -170
Branches 39148 39087 -61
==========================================
- Hits 50745 50738 -7
+ Misses 86963 86800 -163
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
veronikasif
added
the
deprecated:automerge
kodiakhq
bot
deleted the
feat/income-plan-dont-allow-negative-or-zero
branch
[TS-911] Don't allow negative numbers or 0 in income plan
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes