Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(id-card): updates to application #15870

Merged
merged 126 commits into from
Sep 9, 2024
Merged

feat(id-card): updates to application #15870

merged 126 commits into from
Sep 9, 2024

Conversation

berglindoma13
Copy link
Member

@berglindoma13 berglindoma13 commented Sep 3, 2024 •
edited by coderabbitai bot
Loading

...

Attach a link to issue if relevant

What

  • Made changes to the way citizenship affects application, parents with foreign citizenship need to be able to apply for children but not for themselves
  • Modified rules for age of application and screens that appear based on age
  • Made changes to rules regarding II id cards and ID id cards
  • Removed location choice
  • finished second guardian functionality
  • fixed alert messages based on which parent you are and if there are 2 parents that need to approve
  • Moved ID cards to front of radio buttons
  • Added alert when either ID card version is unavailable to the applicant
  • made price messages dynamic based on applicant
  • Modified Price choices from 12 down to 4
  • Added dataprovider for parentB

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced validation for parents based on children's citizenship status.
    • Improved form structure for ID card applications, making it more dynamic and context-aware.
    • Added new utility functions for better applicant data handling and presentation.
    • Updated action card field types for greater flexibility and specificity.
    • Introduced dynamic messaging capabilities based on applicant details.

  • Bug Fixes

    • Corrected approval status handling for second guardian information.

  • Refactor

    • Streamlined eligibility checks and applicant information retrieval processes.
    • Improved control flow for application review processes.

  • Chores

    • Removed deprecated constants and types to enhance code clarity.

berglindoma13 and others added 30 commits April 15, 2024 14:13
@berglindoma13
new application setup
2f7808c
@berglindoma13
Merge branch 'main' into feature/new-nafnskirteini-application
a98fadb
@berglindoma13
new application setup
dc3f217
@berglindoma13
merge conflicts
5aa31da
@berglindoma13
continued work
18cf785
@berglindoma13
stuff
52dd0f6
@berglindoma13
working
0bfe1b5
State for parent B
c8f5fe5
adding overview section to review
93ca69f
confirmation, approved and rejected file
ed2642d
@berglindoma13
adding steps
f812245
@berglindoma13
Merge branch 'feature/new-nafnskirteini-application' of https://githu…
373d145 
…b.com/island-is/island.is into feature/new-nafnskirteini-application
@sigruntg
AssignParentB api action
5203b33
@sigruntg
reject application email
8b62dba
@sigruntg
adding submit application email
6047c8e
@sigruntg
commenting out fjs code in service
1840bc6
@sigruntg
adding chargefjsv2clientmodule to id card module file
945a80a
@berglindoma13
adding rest of steps
be4eadf
@berglindoma13
mergin main
5df0f28
@berglindoma13
Merge branch 'feature/new-nafnskirteini-application' of https://githu…
201583c 
…b.com/island-is/island.is into feature/new-nafnskirteini-application
@berglindoma13
merge conflicst
2b35beb
@sigruntg
fixing merge issues
711d582
@sigruntg
changes to reject conclusion screen
5423000
@sigruntg
..
20a69f9
@sigruntg
accept reject buttons and modal
19eb588
@sigruntg
fixing conclusion screen
2056a67
@berglindoma13
added disability check
91c7704
@berglindoma13
Merge branch 'feature/new-nafnskirteini-application' of https://githu…
99959b4 
…b.com/island-is/island.is into feature/new-nafnskirteini-application
@berglindoma13
dataschema update
38c5745
@berglindoma13
klaraði bakendaföll eins og hægt er í bili
f7aea26
This was referenced Sep 12, 2024
Merged
Merged
Merged
jonnigs pushed a commit that referenced this pull request Sep 12, 2024
@berglindoma13 @sigruntg
@andes-it @AndesKrrrrrrrrrrr @kodiakhq @jonnigs
feat(id-card): updates to application (#15870)
6fe7af5 
* new application setup

* new application setup

* continued work

* stuff

* working

* State for parent B

* adding overview section to review

* confirmation, approved and rejected file

* adding steps

* AssignParentB api action

* reject application email

* adding submit application email

* commenting out fjs code in service

* adding chargefjsv2clientmodule to id card module file

* adding rest of steps

* merge conflicst

* fixing merge issues

* changes to reject conclusion screen

* ..

* accept reject buttons and modal

* fixing conclusion screen

* added disability check

* dataschema update

* klaraði bakendaföll eins og hægt er í bili

* changes in prerequisites

* changes to typeofidsubsection

* chore: charts update dirty files

* changes to condition description

* finishing up

* changing answers

* small changes

* stuff

* payment fix

* merging

* finishing too many things for one commit

* submit application

* config update

* updates

* trying stuff

* working on this

* connection type to id call

* working on this

* rest of updates for applicatin

* removed disability from dataprovider, not only with permission

* removed space

* payment codes

* temp changes, todo finish

* changes to condition for applying to id cards

* finishind touches

* small fix

* typing iddocumenttype

* fixing comments

* fixing comments

* small updates

* fixes for build

* fixes for build

* small update to test

* small update to test

* small update to test

* small update to test

* small updates

* updates to formatText, applicationCard and types

* stuff

* payment code changes

* updates to aplication

* updates to application

* more updates

* more updates

* more updates

* lokapunktar

* cosnole log remove

* more updates

* more updates

* updates after comment

---------

Co-authored-by: Sigrún Tinna Gissurardóttir <[email protected]>
Co-authored-by: Sigrún Tinna Gissurardóttir <[email protected]>
Co-authored-by: andes-it <[email protected]>
Co-authored-by: Kristofer <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This was referenced Sep 13, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 24, 2024
Merged
Merged
Merged
This was referenced Oct 3, 2024
Merged
Merged
Merged
Open
This was referenced Oct 15, 2024
Merged
Merged
Merged
This was referenced Oct 22, 2024
Merged
Merged
This was referenced Oct 30, 2024
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@sigruntg sigruntg sigruntg approved these changes

@disaerna disaerna disaerna approved these changes

@Toti91 Toti91 Toti91 approved these changes

@baering baering baering approved these changes

Assignees
No one assigned
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@berglindoma13 @baering @Toti91 @disaerna @sigruntg @andes-it @AndesKrrrrrrrrrrr