fix(id-card): fixed message to user

[berglindoma13]

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Enhanced the review process by determining pending actions based on user roles instead of national IDs.
  • Streamlined logic for pending action messages, improving clarity and efficiency.

• Bug Fixes

  • Removed unnecessary checks related to national IDs, simplifying the function's conditions.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the IdCardTemplate.ts file, specifically modifying the reviewStatePendingAction function to replace the nationalId parameter with a role parameter. This adjustment alters the logic to determine pending actions based on user roles instead of national IDs. The function now checks if the user role is 'assignee' and whether the application is unapproved, simplifying the conditions for returning pending action messages. The mapUserToRole method was also updated to reflect this change.

Changes

File Path	Change Summary
libs/application/templates/id-card/src/lib/IdCardTemplate.ts	Updated reviewStatePendingAction to replace nationalId with role. Simplified logic for pending actions. Updated mapUserToRole method signature contextually related to the changes.

Possibly related PRs

• feat(id-card): updates to application #15870: This PR involves updates to the IdCardTemplate and includes changes to the Approved.ts file, which may relate to the overall structure and logic of ID card processing.
• fix(id-card): email for parent B fix #16394: This PR modifies the assignParentBEmail.ts and Rejected.ts files, which are part of the ID card functionality, potentially relating to the modifications in IdCardTemplate.ts.
• fix(citizenship): indexing error on child support documents #16469: This PR addresses indexing errors in child support documents, which may connect to the logic changes in IdCardTemplate.ts regarding user roles and application states.

Suggested labels

automerge

Suggested reviewers

• sigruntg
• Ballioli

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cf03b8c and 48ae9d7.

📒 Files selected for processing (1)

• libs/application/templates/id-card/src/lib/IdCardTemplate.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

libs/application/templates/id-card/src/lib/IdCardTemplate.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.77%. Comparing base (a6ab2b4) to head (99922ff).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...cation/templates/id-card/src/lib/IdCardTemplate.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16516   +/-   ##
=======================================
  Coverage   36.77%   36.77%           
=======================================
  Files        6858     6858           
  Lines      142423   142419    -4     
  Branches    40623    40620    -3     
=======================================
  Hits        52378    52378           
+ Misses      90045    90041    -4     

Flag	Coverage Δ
api	3.37% <ø> (ø)
application-system-api	41.36% <0.00%> (+<0.01%)	⬆️
application-template-api-modules	27.80% <ø> (+0.01%)	⬆️
application-ui-shell	21.24% <ø> (ø)
portals-admin-regulations-admin	1.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...cation/templates/id-card/src/lib/IdCardTemplate.ts	28.84% <0.00%> (+2.06%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ab2b4...99922ff. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 5964558 🔗

✅ 5 Total Test Services: 0 Failed, 5 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.01%), 9 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	3.05s	1 no change	Link
application-system-api	0	0	0	120	2	3m 13.16s	1 no change	Link
application-template-api-modules	0	0	0	123	0	2m 40.02s	1 increased (+0.01%)	Link
application-ui-shell	0	0	0	74	0	35.91s	1 no change	Link
portals-admin-regulations-admin	0	0	0	24	0	15.06s	1 no change	Link