-
Notifications
You must be signed in to change notification settings - Fork 3k
Tests material binding inside stage in memory test #4347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Greptile Summary
Important Files Changed
Confidence score: 4/5
Sequence DiagramsequenceDiagram
participant TestRunner
participant SimulationContext
participant StageUtils as "sim_utils"
participant MaterialBinder as "bind_physics_material"
participant Stage as "USD Stage"
participant PhysX
TestRunner->>SimulationContext: "SimulationContext(create_stage_in_memory=True)"
SimulationContext->>StageUtils: "create_new_stage_in_memory()"
StageUtils-->>SimulationContext: "stage_in_memory"
SimulationContext->>SimulationContext: "_set_additional_physx_params()"
SimulationContext->>MaterialBinder: "bind_physics_material(physics_prim_path, material_path)"
MaterialBinder-->>SimulationContext: "material bound"
TestRunner->>SimulationContext: "get_initial_stage()"
SimulationContext-->>TestRunner: "stage_in_memory"
TestRunner->>StageUtils: "use_stage(stage_in_memory)"
TestRunner->>StageUtils: "create_prim('/World/env_*')"
TestRunner->>StageUtils: "MultiAssetSpawnerCfg.func()"
StageUtils->>Stage: "spawn assets with materials"
Stage-->>StageUtils: "assets created"
TestRunner->>StageUtils: "is_current_stage_in_memory()"
StageUtils-->>TestRunner: "True"
TestRunner->>StageUtils: "find_matching_prim_paths()"
StageUtils->>Stage: "query prims"
Stage-->>StageUtils: "prim paths"
StageUtils-->>TestRunner: "prims found in memory stage"
TestRunner->>StageUtils: "attach_stage_to_usd_context()"
StageUtils->>Stage: "attach to USD context"
StageUtils->>PhysX: "update physics with stage"
PhysX-->>StageUtils: "physics updated"
TestRunner->>StageUtils: "find_matching_prim_paths()"
StageUtils-->>TestRunner: "prims verified in context stage"
|
Edify0991
pushed a commit
to Edify0991/IsaacLab
that referenced
this pull request
Jan 14, 2026
# Description Previously the stage in memory test did not check if material binding worked correctly. During my debugging, I saw that the `bind_visual_material` command was failing. This MR adds a fix for it and makes the test check for mateiral binding as well. Requires merging: isaac-sim#4337 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the stage in memory test did not check if material binding worked correctly. During my debugging, I saw that the
bind_visual_materialcommand was failing. This MR adds a fix for it and makes the test check for mateiral binding as well.Requires merging: #4337
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there