-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Moves flake8 settings to pyproject #4335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile SummaryThis PR consolidates flake8 configuration from Key Changes
Issues Found
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PreCommit as pre-commit
participant Black as Black Formatter
participant Flake8 as Flake8 Linter
participant PyProject as pyproject.toml
Dev->>PreCommit: git commit
PreCommit->>Black: Run black formatter
Black->>PyProject: Read [tool.black] config
Note over Black,PyProject: line-length=120<br/>unstable=true
Black-->>PreCommit: Format OK
PreCommit->>Flake8: Run flake8 linter (v7.1.0)
Flake8->>PyProject: Read [tool.flake8] config via Flake8-pyproject
Note over Flake8,PyProject: Previously read from .flake8<br/>Now centralized in pyproject.toml
Flake8->>Flake8: Check Python files
Note over Flake8: Skip F401 for __init__.py<br/>Use dynamic imports with __name__
Flake8-->>PreCommit: Linting OK
PreCommit-->>Dev: All checks passed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
pyproject.toml, line 37-42 (link)logic: the exclude pattern changed from
_*(which excludes all files/dirs starting with underscore) to only_isaac_sim/**. whiledocs/**is already included, this might now lint other underscore-prefixed directories like_compileror__pycache__that were previously excluded.
6 files reviewed, 1 comment
Description
Another small step towards switching over to ruff.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there