-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix grasp #4157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix grasp #4157
Conversation
Greptile OverviewGreptile SummaryThis PR addresses two bugs in the AutoMate assembly environments:
The changes simplify the codebase by removing unnecessary CUDA version checking logic while enabling proper CUDA 13 support through updated dependencies ( Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant AssemblyEnv
participant SoftDTW
participant CUDA
User->>AssemblyEnv: Reset Episode
AssemblyEnv->>AssemblyEnv: _reset_idx()
AssemblyEnv->>AssemblyEnv: randomize_initial_state()
AssemblyEnv->>AssemblyEnv: Close gripper (1.0s grasp time)
Note over AssemblyEnv: Previously 0.25s, now 1.0s<br/>ensures full grasp
User->>AssemblyEnv: Step (action)
AssemblyEnv->>AssemblyEnv: _get_rewards()
AssemblyEnv->>SoftDTW: Compute DTW reward
SoftDTW->>CUDA: GPU computation (always enabled)
Note over SoftDTW,CUDA: CUDA version check removed<br/>Now uses numba.cuda import
CUDA-->>SoftDTW: DTW result
SoftDTW-->>AssemblyEnv: Imitation reward
AssemblyEnv-->>User: reward, done
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
docs/source/overview/environments.rst, line 276-277 (link)style: Missing blank line before
.. code-block::directive. In RST, directives should have a blank line before them for proper rendering.
4 files reviewed, 1 comment
Description
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.

Before:
After:

Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there