Skip to content

Conversation

@pascal-roth
Copy link
Collaborator

Description

Cleans up new util functions

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Nov 19, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 19, 2025

Greptile Summary

  • Modernized imports by switching from import typing to specific imports (Literal, Callable, Iterable) and added Literal["x", "y", "z"] type hint for axis parameter
  • Replaced get_carb_setting() wrapper function with direct carb_setting.get() call and removed unused import
  • Removed parameter names from multiple docstring Args sections (e.g., attaching_early:, stage:, usd_path:), which is inconsistent with codebase documentation standards used in other files like nucleus.py and actuator_base.py

Confidence Score: 4/5

  • This PR is safe to merge with minor style inconsistencies
  • The code changes are functionally correct (improved imports, removed wrapper function). The main issue is documentation style inconsistency where parameter names were removed from docstrings, deviating from the codebase standard. No logic errors or security issues.
  • The docstring changes in stage.py should be reviewed to ensure consistency with project documentation standards

Important Files Changed

Filename Overview
source/isaaclab/isaaclab/sim/utils/stage.py Cleaned up imports and replaced wrapper function call, but removed parameter names from docstrings inconsistently with codebase standards

Sequence Diagram

sequenceDiagram
    participant User
    participant Stage
    participant CarbSettings
    participant PhysX
    participant USDContext
    
    User->>Stage: attach_stage_to_usd_context(attaching_early)
    Stage->>Stage: Check Isaac Sim version
    Stage->>Stage: Check if stage is in memory
    Stage->>PhysX: attach_stage(stage_id)
    Stage->>CarbSettings: get("/physics/fabricUpdateTransformations")
    CarbSettings-->>Stage: is_rendering_enabled
    alt rendering enabled
        Stage->>USDContext: attach_stage_with_callback(stage_id)
        Stage->>PhysX: attach_stage(stage_id)
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 6 comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@pascal-roth pascal-roth changed the title Cleans up new util functions Removes instances of IsaacSim SimulationContext Nov 23, 2025
@Mayankm96
Copy link
Contributor

@pascal-roth can you please fix the merge conflicts in here?

@pascal-roth
Copy link
Collaborator Author

@Mayankm96 everything resolved, ready to go

@Mayankm96 Mayankm96 moved this to In progress in Isaac Lab Jan 12, 2026
@Mayankm96 Mayankm96 changed the title Removes instances of IsaacSim SimulationContext Removes usage of IsaacSim SimulationContext inside tests Jan 15, 2026
@Mayankm96
Copy link
Contributor

For some reason many tests are timing out. Going to run the job again before merging.

@pascal-roth
Copy link
Collaborator Author

the tests are timing out when checking if the omni.timeline is still playing and then enter an infite rendering call

while not omni.timeline.get_timeline_interface().is_playing()

Meaning something in the scene is preventing the destruction. This check has been commented out in the new PR
#4324

So maybe lets merge that first and then these changes here should be work. What do you think @Mayankm96

@Mayankm96
Copy link
Contributor

Mayankm96 commented Jan 22, 2026

@pascal-roth You can set this variable to True inside the tests for now: https://github.com/isaac-sim/IsaacLab/blob/main/source/isaaclab/isaaclab/sim/simulation_context.py#L257

The changes in #4324 will not land into main. They will go into the develop branch based on my understanding.

@pascal-roth pascal-roth requested a review from Mayankm96 January 25, 2026 16:37
@pascal-roth
Copy link
Collaborator Author

@Mayankm96 should be good now with the tests (locally they pass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants