Skip to content

Conversation

@hhansen-bdai
Copy link
Collaborator

Description

pre-commit CI runs have been failing (see example) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@github-actions github-actions bot added bug Something isn't working infrastructure labels Nov 3, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Fixes failing pre-commit CI runs by pinning Python version to 3.12 in the GitHub Actions workflow.

  • Added python-version: "3.12" parameter to actions/setup-python@v3 step
  • Addresses incompatibility between flake8 7.0.0 (specified in .pre-commit-config.yaml) and Python 3.14
  • Previously, setup-python@v3 defaulted to latest Python version (3.14), which caused pre-commit failures
  • Python 3.12 is compatible with all pre-commit hooks and aligns with the project's Python version usage in other workflows

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is minimal, well-scoped, and directly addresses a documented CI failure. Pinning Python to 3.12 is a safe choice that aligns with other workflows in the repository (license-check uses 3.11, docs uses 3.11) and ensures compatibility with flake8 7.0.0.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/pre-commit.yaml 5/5 Pinned Python to 3.12 to fix flake8 7.0.0 incompatibility with Python 3.14

Sequence Diagram

sequenceDiagram
    participant PR as Pull Request
    participant GHA as GitHub Actions
    participant Setup as setup-python@v3
    participant PreCommit as pre-commit/action
    participant Flake8 as flake8 7.0.0
    
    PR->>GHA: Trigger workflow (opened/sync/reopen)
    GHA->>Setup: Install Python
    Note over Setup: Without version: installs latest (3.14)
    Note over Setup: With version "3.12": installs 3.12
    Setup->>GHA: Python environment ready
    GHA->>PreCommit: Run pre-commit hooks
    PreCommit->>Flake8: Execute flake8 linting
    alt Python 3.14 (before fix)
        Flake8->>PreCommit: ❌ Incompatibility error
        PreCommit->>GHA: Workflow fails
    else Python 3.12 (after fix)
        Flake8->>PreCommit: ✓ Linting complete
        PreCommit->>GHA: Workflow succeeds
    end
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Test Results Summary

2 669 tests   2 207 ✅  2h 27m 26s ⏱️
   99 suites    461 💤
    1 files        1 ❌

For more details on these failures, see this check.

Results for commit 6506a89.

@kellyguo11 kellyguo11 changed the title Pinned python version of pre-commmit.yaml workflow Pins python version of pre-commmit.yaml workflow Nov 3, 2025
@kellyguo11 kellyguo11 merged commit 76f5b29 into main Nov 3, 2025
9 of 11 checks passed
@kellyguo11 kellyguo11 deleted the hhansen/fix_precommit_gha_python_version branch November 3, 2025 21:20
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
with:
python-version: "3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Isaac Sim 5.1 use Python 3.12 or 3.11? Might make sense to keep the version similar to that?

Copy link

@d-kleine d-kleine Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, IsaacSim requires Python 3.11, other versions don't work:
https://docs.isaacsim.omniverse.nvidia.com/latest/installation/install_python.html

From my point-of-view, this needs to be fixed. Tagging @hhansen-bdai for heads-up

gattra-rai pushed a commit to gattra-rai/IsaacLab that referenced this pull request Nov 17, 2025
# Description

pre-commit CI runs have been failing (see
[example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424))
due to an incompatibility between our specified flake version and python
3.14, as python3.14 has started to be installed by the setup-python GHA.
This PR pins python to 3.12 in order to fix these failures.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
kellyguo11 pushed a commit that referenced this pull request Nov 26, 2025
# Description

pre-commit CI runs have been failing (see
[example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424))
due to an incompatibility between our specified flake version and python
3.14, as python3.14 has started to be installed by the setup-python GHA.
This PR pins python to 3.12 in order to fix these failures.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
kellyguo11 pushed a commit that referenced this pull request Nov 26, 2025
# Description

pre-commit CI runs have been failing (see
[example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424))
due to an incompatibility between our specified flake version and python
3.14, as python3.14 has started to be installed by the setup-python GHA.
This PR pins python to 3.12 in order to fix these failures.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
koghalai123 pushed a commit to koghalai123/IsaacLab that referenced this pull request Dec 7, 2025
# Description

pre-commit CI runs have been failing (see
[example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424))
due to an incompatibility between our specified flake version and python
3.14, as python3.14 has started to be installed by the setup-python GHA.
This PR pins python to 3.12 in order to fix these failures.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
Edify0991 pushed a commit to Edify0991/IsaacLab that referenced this pull request Jan 14, 2026
# Description

pre-commit CI runs have been failing (see
[example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424))
due to an incompatibility between our specified flake version and python
3.14, as python3.14 has started to be installed by the setup-python GHA.
This PR pins python to 3.12 in order to fix these failures.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants