-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Pins python version of pre-commmit.yaml workflow #3929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
Fixes failing pre-commit CI runs by pinning Python version to 3.12 in the GitHub Actions workflow.
- Added
python-version: "3.12"parameter toactions/setup-python@v3step - Addresses incompatibility between flake8 7.0.0 (specified in
.pre-commit-config.yaml) and Python 3.14 - Previously,
setup-python@v3defaulted to latest Python version (3.14), which caused pre-commit failures - Python 3.12 is compatible with all pre-commit hooks and aligns with the project's Python version usage in other workflows
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- The change is minimal, well-scoped, and directly addresses a documented CI failure. Pinning Python to 3.12 is a safe choice that aligns with other workflows in the repository (license-check uses 3.11, docs uses 3.11) and ensures compatibility with flake8 7.0.0.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/pre-commit.yaml | 5/5 | Pinned Python to 3.12 to fix flake8 7.0.0 incompatibility with Python 3.14 |
Sequence Diagram
sequenceDiagram
participant PR as Pull Request
participant GHA as GitHub Actions
participant Setup as setup-python@v3
participant PreCommit as pre-commit/action
participant Flake8 as flake8 7.0.0
PR->>GHA: Trigger workflow (opened/sync/reopen)
GHA->>Setup: Install Python
Note over Setup: Without version: installs latest (3.14)
Note over Setup: With version "3.12": installs 3.12
Setup->>GHA: Python environment ready
GHA->>PreCommit: Run pre-commit hooks
PreCommit->>Flake8: Execute flake8 linting
alt Python 3.14 (before fix)
Flake8->>PreCommit: ❌ Incompatibility error
PreCommit->>GHA: Workflow fails
else Python 3.12 (after fix)
Flake8->>PreCommit: ✓ Linting complete
PreCommit->>GHA: Workflow succeeds
end
1 file reviewed, no comments
Test Results Summary2 669 tests 2 207 ✅ 2h 27m 26s ⏱️ For more details on these failures, see this check. Results for commit 6506a89. |
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Isaac Sim 5.1 use Python 3.12 or 3.11? Might make sense to keep the version similar to that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, IsaacSim requires Python 3.11, other versions don't work:
https://docs.isaacsim.omniverse.nvidia.com/latest/installation/install_python.html
From my point-of-view, this needs to be fixed. Tagging @hhansen-bdai for heads-up
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
Description
pre-commit CI runs have been failing (see example) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures.
Type of change