Skip to content

Conversation

renezurbruegg
Copy link
Collaborator

@renezurbruegg renezurbruegg commented Oct 15, 2025

Description

Adds preserve_order flag to JointPositionToLimitsActionCfg

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added enhancement New feature or request isaac-lab Related to Isaac Lab team labels Oct 15, 2025
Copy link
Collaborator

@ooctipus ooctipus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me, though can you share what bug you went into without it?

Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mayankm96 Mayankm96 moved this to In review in Isaac Lab Oct 16, 2025
@renezurbruegg
Copy link
Collaborator Author

The changes looks good to me, though can you share what bug you went into without it?

Without the preserving order flag, the order of the joints in the action term are defined by the internal parsing of physx.
So e,g, providing ["index_q1", "middle_q1", "ring_q1"] as joint expressions (with preserve_order=False, which is the default), can lead to the action term internally using ["ring_q1", "middle_q1", "index_q1"] as joint order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request isaac-lab Related to Isaac Lab team

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants