-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Store black
configuration in pyproject.toml
and enhance pyright
support
#3619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/newton
Are you sure you want to change the base?
Store black
configuration in pyproject.toml
and enhance pyright
support
#3619
Conversation
Signed-off-by: Diego Ferigo <[email protected]>
Signed-off-by: Diego Ferigo <[email protected]>
@ClemensSchwarke Following up here with our discussion to switch to ruff entirely :) |
I'd be super happy about a |
Hey @diegoferigo-rai, I think it would be super nice if you could add the ruff configuration for the parts you are interested in. I can take care of the remaining integration. |
The transition However, the It would be helpful if someone could provide context on why the default isort or ruff’s built-in linter isn't sufficient for this project. From my perspective, many of these custom rules seem like a workaround for other underlying issues rather than something inherently required. Lines 10 to 64 in f52aa98
|
I am not sure of the reasons for this isort setup (maybe @Mayankm96 can help), but I think it should be fairly easy to have a similar configuration for ruff. |
I think back then isort was sorting them out alphabetically (don't remember a 100%). I wanted to group the imports based on their types (as expressed in the list) to make it easier to read through the imports. |
Description
This PR updates the
pyproject.toml
configuration to improve compatibility with tooling such asblack
andpyright
. The changes affect both standalone usage of these tools and their integration when invoked from IDEs like VSCode.This allows users who are not interested in autogenerating the
settings.json
file to have their IDEs configured out of the box.This approach could be also extended to other tools like flake, pylint, etc.
Note
This PR targets
feature/newton
, which is the branch I'm currently interested. It can be backported tomain
if needed.Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there