Reapply "[DispatchCreation] Extend multi-use producer fusion"#19032
Merged
IanWood1 merged 2 commits intoiree-org:mainfrom Nov 5, 2024
Merged
Reapply "[DispatchCreation] Extend multi-use producer fusion"#19032IanWood1 merged 2 commits intoiree-org:mainfrom
IanWood1 merged 2 commits intoiree-org:mainfrom
Conversation
IanWood1
requested review from
MaheshRavishankar,
ScottTodd and
hanhanW
as code owners
MaheshRavishankar
approved these changes
Nov 5, 2024
IanWood1
changed the title
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
MaheshRavishankar
added a commit
to MaheshRavishankar/iree
that referenced
this pull request
Nov 8, 2024
…iree-org#19032)" This reverts commit 2a5d123. Seems to cause accuracy regressions nod-ai/amd-shark-ai#437 Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
MaheshRavishankar
added a commit
that referenced
this pull request
Nov 8, 2024
…#19032) (#19070) This reverts commit 2a5d123. Seems to cause accuracy regressions nod-ai/amd-shark-ai#437 Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…rg#19032) Since the upstream changes to `getBackwardSlice` have been integrated (llvm/llvm-project#114452), its now possible to reland iree-org#18855. The first commit relands the reverted changes. The second commit uses `BackwardSliceOptions::omitUsesFromAbove` to track all transitive definitions of the possibly fusible op preventing ops being moved before uses. Also, added two tests that check for this issue. Closes iree-org#18879 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…iree-org#19032) (iree-org#19070) This reverts commit 2a5d123. Seems to cause accuracy regressions nod-ai/amd-shark-ai#437 Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…rg#19032) Since the upstream changes to `getBackwardSlice` have been integrated (llvm/llvm-project#114452), its now possible to reland iree-org#18855. The first commit relands the reverted changes. The second commit uses `BackwardSliceOptions::omitUsesFromAbove` to track all transitive definitions of the possibly fusible op preventing ops being moved before uses. Also, added two tests that check for this issue. Closes iree-org#18879 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…iree-org#19032) (iree-org#19070) This reverts commit 2a5d123. Seems to cause accuracy regressions nod-ai/amd-shark-ai#437 Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Dec 10, 2024
iree-org#19032) (iree-org#19070) This reverts commit be41632. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
kuhar
pushed a commit
to kuhar/iree
that referenced
this pull request
Dec 11, 2024
…org#19431) Re-land changes to multi-use fusion iree-org#19032 after iree-org#19389 which fixes shortfin integration tests. This PR was causing the compiler to go down a path that exposed a bug in Stream. Closes iree-org#19411 This reverts commit be41632. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the upstream changes to
getBackwardSlicehave been integrated (llvm/llvm-project#114452), its now possible to reland #18855.The first commit relands the reverted changes. The second commit uses
BackwardSliceOptions::omitUsesFromAboveto track all transitive definitions of the possibly fusible op preventing ops being moved before uses. Also, added two tests that check for this issue.Closes #18879