Reapply "[DispatchCreation] Extend multi-use producer fusion…"#19431
Merged
IanWood1 merged 1 commit intoiree-org:mainfrom Dec 11, 2024
Merged
Reapply "[DispatchCreation] Extend multi-use producer fusion…"#19431IanWood1 merged 1 commit intoiree-org:mainfrom
IanWood1 merged 1 commit intoiree-org:mainfrom
Conversation
iree-org#19032) (iree-org#19070) This reverts commit be41632. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Contributor
Author
|
I just confirmed that the tests pass after rebasing on top of main |
Contributor
|
nit: I think we can fold the |
hanhanW
approved these changes
Dec 11, 2024
IanWood1
changed the title
kuhar
pushed a commit
to kuhar/iree
that referenced
this pull request
Dec 11, 2024
…org#19431) Re-land changes to multi-use fusion iree-org#19032 after iree-org#19389 which fixes shortfin integration tests. This PR was causing the compiler to go down a path that exposed a bug in Stream. Closes iree-org#19411 This reverts commit be41632. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
IanWood1
added a commit
that referenced
this pull request
Dec 11, 2024
There appears to be more problems with this change. This is causing compilation failure with 405b due to huge program slices during multi use fusion. `getBackwardSlice` is recursive so it is causing a stack overflow. Reverts #19431
AWoloszyn
pushed a commit
that referenced
this pull request
Dec 1, 2025
There appears to be more problems with this change. This is causing compilation failure with 405b due to huge program slices during multi use fusion. `getBackwardSlice` is recursive so it is causing a stack overflow. Reverts #19431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-land changes to multi-use fusion #19032 after #19389 which fixes shortfin integration tests. This PR was causing the compiler to go down a path that exposed a bug in Stream.
Closes #19411
This reverts commit be41632.