Fix error in FuseMultiUseElementwiseProducersPass#18855
Closed
IanWood1 wants to merge 3 commits intoiree-org:mainfrom
Closed
Fix error in FuseMultiUseElementwiseProducersPass#18855IanWood1 wants to merge 3 commits intoiree-org:mainfrom
IanWood1 wants to merge 3 commits intoiree-org:mainfrom
Conversation
Contributor
Author
|
This pass is very brittle because any constant hoisted out of a Edit: this is separate from this PR. I created an issue here #18856 |
`op` isn't included in `slice` so it must be independently checked to make sure it doesn't use any values defined above. Otherwise, a consumer that uses values defined above may be fused with a producer causing dominance errors. Closes iree-org#18847 Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
IanWood1
force-pushed
the
fix_multi_use_fusion_error
branch
from
37e4da8 to
89d8862
Compare
Collaborator
|
I think this is basically a bug in |
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Contributor
Author
I have something working, but the wrapper needs some cleanup because it's a bit confusing. |
IanWood1
added a commit
that referenced
this pull request
Oct 28, 2024
The reverted commit does not handle when the "consumer" uses a value defined above. See #18879 for the original issue. This is causing issue with ~15 onnx models. I have a PR (#18855) to fix this by including values used in an ops region in the backwards slice, but It is waiting on upstream changes to `getBackwardSlice`. Currently, the PR is using a wrapper around `getBackwardSlice` to acheive the same effect, but this will be updated once the upstream change lands (llvm/llvm-project#113478) Reverts #18551 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Eliasj42
pushed a commit
that referenced
this pull request
Oct 31, 2024
The reverted commit does not handle when the "consumer" uses a value defined above. See #18879 for the original issue. This is causing issue with ~15 onnx models. I have a PR (#18855) to fix this by including values used in an ops region in the backwards slice, but It is waiting on upstream changes to `getBackwardSlice`. Currently, the PR is using a wrapper around `getBackwardSlice` to acheive the same effect, but this will be updated once the upstream change lands (llvm/llvm-project#113478) Reverts #18551 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu> Signed-off-by: Elias Joseph <eljoseph@amd.com>
Contributor
Author
IanWood1
added a commit
that referenced
this pull request
Nov 5, 2024
Since the upstream changes to `getBackwardSlice` have been integrated (llvm/llvm-project#114452), its now possible to reland #18855. The first commit relands the reverted changes. The second commit uses `BackwardSliceOptions::omitUsesFromAbove` to track all transitive definitions of the possibly fusible op preventing ops being moved before uses. Also, added two tests that check for this issue. Closes #18879 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…rg#19032) Since the upstream changes to `getBackwardSlice` have been integrated (llvm/llvm-project#114452), its now possible to reland iree-org#18855. The first commit relands the reverted changes. The second commit uses `BackwardSliceOptions::omitUsesFromAbove` to track all transitive definitions of the possibly fusible op preventing ops being moved before uses. Also, added two tests that check for this issue. Closes iree-org#18879 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…g#18917) The reverted commit does not handle when the "consumer" uses a value defined above. See iree-org#18879 for the original issue. This is causing issue with ~15 onnx models. I have a PR (iree-org#18855) to fix this by including values used in an ops region in the backwards slice, but It is waiting on upstream changes to `getBackwardSlice`. Currently, the PR is using a wrapper around `getBackwardSlice` to acheive the same effect, but this will be updated once the upstream change lands (llvm/llvm-project#113478) Reverts iree-org#18551 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…rg#19032) Since the upstream changes to `getBackwardSlice` have been integrated (llvm/llvm-project#114452), its now possible to reland iree-org#18855. The first commit relands the reverted changes. The second commit uses `BackwardSliceOptions::omitUsesFromAbove` to track all transitive definitions of the possibly fusible op preventing ops being moved before uses. Also, added two tests that check for this issue. Closes iree-org#18879 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isHorizontalToGroupdoesn't checkopto make sure it doesn't use any values defined above. This is a workaround for the fact thatgetBackwardsSlicedoesn't track ops if they are used in the region but not as an operand to the operation.Closes #18847