refactor: use the built-in max/min to simplify the code [skip changelog]#941
refactor: use the built-in max/min to simplify the code [skip changelog]#941
Conversation
Signed-off-by: overallteach <cricis@foxmail.com>
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
|
It seems this issue might have been automatically generated. To help us address it effectively, please provide additional details. We value the use of LLMs for code generation and welcome your contributions but please ensure your submission is of such quality that a maintainer will spend less time reviewing it than implementing it themselves. Verify the code functions correctly and meets our standards. If your change requires tests, kindly include them and ensure they pass. If no further information is provided, the issue will be automatically closed in 7 days. Thank you for your understanding and for aiding us in maintaining quality contributions! |
|
Not LLMs. This change can make the code more clean. |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 61.59% 61.59% -0.01%
==========================================
Files 254 254
Lines 31400 31396 -4
==========================================
- Hits 19341 19337 -4
+ Misses 10487 10486 -1
- Partials 1572 1573 +1
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.