Skip to content

Comments

refactor: use the built-in max/min to simplify the code [skip changelog]#1014

Closed
wmypku wants to merge 1 commit intoipfs:mainfrom
wmypku:main
Closed

refactor: use the built-in max/min to simplify the code [skip changelog]#1014
wmypku wants to merge 1 commit intoipfs:mainfrom
wmypku:main

Conversation

@wmypku
Copy link

@wmypku wmypku commented Aug 26, 2025

Inspired by #941 and replace all.

Signed-off-by: wmypku <wmypku@outlook.com>
@wmypku wmypku requested a review from a team as a code owner August 26, 2025 10:06
@welcome
Copy link

welcome bot commented Aug 26, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@guillaumemichel guillaumemichel added the kind/nonfunctional Nonfunctional change (spelling, formatting, etc.) label Aug 26, 2025
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.50%. Comparing base (30868de) to head (72ea9da).
⚠️ Report is 2 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
+ Coverage   60.47%   60.50%   +0.02%     
==========================================
  Files         267      267              
  Lines       33276    33276              
==========================================
+ Hits        20124    20133       +9     
+ Misses      11485    11477       -8     
+ Partials     1667     1666       -1     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gammazero
Copy link
Contributor

Handled in #1017

@gammazero gammazero closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/nonfunctional Nonfunctional change (spelling, formatting, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants