Skip to content

Conversation

@valeriyr
Copy link
Contributor

@valeriyr valeriyr commented Apr 10, 2025

Description of change

The following list contains the changes that can be highlighted:

  1. [trace-view] Added support for displaying disassembly view.
  2. [move] moves tree sitter code from the repository.
  3. [trace-view] Start debugging in disassembly.
  4. [test-infra] Replace Move's .exp tests with cargo-insta.
  5. [iota-execution] Enabled tracing in the execution layer.

Links to any relevant issues

fixes #6216
fixes #6228
fixes #6227

@vercel
Copy link

vercel bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 3:35pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 3:35pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 3:35pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 3:35pm

@iota-ci iota-ci added sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Apr 10, 2025
@github-actions github-actions bot added ci Issues related to our CI pipeline and removed sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Apr 10, 2025
@valeriyr valeriyr force-pushed the vm-lang/issue-6216-external-crates-1-43-1 branch from 6c5b5eb to 8ec5384 Compare April 10, 2025 11:18
@iota-ci iota-ci added sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Apr 10, 2025
@valeriyr valeriyr changed the title feat(external-crates): update from the mainnet-v1.43.1 upstream version [DO NOT MERGE] feat(external-crates): update from the mainnet-v1.43.1 upstream version Apr 11, 2025
@valeriyr valeriyr marked this pull request as ready for review April 11, 2025 08:08
@valeriyr valeriyr requested review from a team as code owners April 11, 2025 08:08
@valeriyr valeriyr changed the title [DO NOT MERGE] feat(external-crates): update from the mainnet-v1.43.1 upstream version feat(external-crates): update from the mainnet-v1.43.1 upstream version Apr 14, 2025
@DaughterOfMars
Copy link
Contributor

Can you rebase to remove the merge commits?

@valeriyr
Copy link
Contributor Author

Can you rebase to remove the merge commits?

They will be squashed anyway. Do they affect the review somehow? To be honest I don't really like to force push such PRs :)

Copy link
Contributor

@muXxer muXxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the files that are owned by core-protocol or node team. Rest I didn't check

@DaughterOfMars
Copy link
Contributor

Can you rebase to remove the merge commits?

They will be squashed anyway. Do they affect the review somehow? To be honest I don't really like to force push such PRs :)

Why are they squashed? Isn't this supposed to pull these commits as-is?

@valeriyr
Copy link
Contributor Author

Can you rebase to remove the merge commits?

They will be squashed anyway. Do they affect the review somehow? To be honest I don't really like to force push such PRs :)

Why are they squashed? Isn't this supposed to pull these commits as-is?

I squash them usually

@miker83z miker83z force-pushed the vm-lang/upstream-feb-24 branch from fd81a06 to 19d49b6 Compare April 15, 2025 15:47
@valeriyr valeriyr marked this pull request as ready for review April 16, 2025 09:35
@valeriyr valeriyr linked an issue Apr 16, 2025 that may be closed by this pull request
@TheMrAI TheMrAI force-pushed the vm-lang/upstream-feb-24 branch from 5adaedf to f8c0eb8 Compare April 16, 2025 13:13
@valeriyr valeriyr force-pushed the vm-lang/issue-6216-external-crates-1-43-1 branch from 6b482aa to 6167a0d Compare April 16, 2025 14:10
Copy link
Contributor

@miker83z miker83z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergiupopescu199 sergiupopescu199 self-requested a review April 18, 2025 08:47
@valeriyr valeriyr merged commit 08e86ce into vm-lang/upstream-feb-24 Apr 18, 2025
36 checks passed
@valeriyr valeriyr deleted the vm-lang/issue-6216-external-crates-1-43-1 branch April 18, 2025 09:54
miker83z pushed a commit that referenced this pull request May 7, 2025
…on (#6354)

The following list contains the changes that can be highlighted:
1. [trace-view] Added support for displaying disassembly view.
2. [move] moves tree sitter code from the
[repository](https://github.com/tzakian/tree-sitter-move).
3. [trace-view] Start debugging in disassembly.
4. [test-infra] Replace Move's .exp tests with cargo-insta.
5. [iota-execution] Enabled tracing in the execution layer.

fixes #6216
fixes #6228
fixes #6227

---------

Co-authored-by: Adam Welc <[email protected]>
muXxer pushed a commit that referenced this pull request Jun 10, 2025
#6929)

# Description of change

- Upstream range: [v1.35.4, v1.36.2)
- Port the following Sui's commits which are contained in the single PR
MystenLabs/sui#19029
-
MystenLabs/sui@bf9ac99
-
MystenLabs/sui@ea27dff
-
MystenLabs/sui@066a6b6

- Descriptions from commits
  - transaction-executor: add simulate_transaction trait method
  - rest: introduce transaction simulation endpoint
  - rest: introduce transaction resolve endpoint
  
- Notes
- The extra field `trace_builder_opt` of
`execute_transaction_to_effects` was introduced in
#6354
  - Because the `iota-sdk-types` does not exit, use `iota-sdk2` instead
  - Remove stable/unstable description in openapi.json from #6922

## Links to any relevant issues

Part of #3990 

## Type of change

- Enhancement (a non-breaking change which adds functionality)

---------

Co-authored-by: jkrvivian <[email protected]>
muXxer pushed a commit that referenced this pull request Jun 10, 2025
#6929)

# Description of change

- Upstream range: [v1.35.4, v1.36.2)
- Port the following Sui's commits which are contained in the single PR
MystenLabs/sui#19029
-
MystenLabs/sui@bf9ac99
-
MystenLabs/sui@ea27dff
-
MystenLabs/sui@066a6b6

- Descriptions from commits
  - transaction-executor: add simulate_transaction trait method
  - rest: introduce transaction simulation endpoint
  - rest: introduce transaction resolve endpoint
  
- Notes
- The extra field `trace_builder_opt` of
`execute_transaction_to_effects` was introduced in
#6354
  - Because the `iota-sdk-types` does not exit, use `iota-sdk2` instead
  - Remove stable/unstable description in openapi.json from #6922

## Links to any relevant issues

Part of #3990 

## Type of change

- Enhancement (a non-breaking change which adds functionality)

---------

Co-authored-by: jkrvivian <[email protected]>
filipdulic pushed a commit that referenced this pull request Jul 16, 2025
#6929)

# Description of change

- Upstream range: [v1.35.4, v1.36.2)
- Port the following Sui's commits which are contained in the single PR
MystenLabs/sui#19029
-
MystenLabs/sui@bf9ac99
-
MystenLabs/sui@ea27dff
-
MystenLabs/sui@066a6b6

- Descriptions from commits
  - transaction-executor: add simulate_transaction trait method
  - rest: introduce transaction simulation endpoint
  - rest: introduce transaction resolve endpoint
  
- Notes
- The extra field `trace_builder_opt` of
`execute_transaction_to_effects` was introduced in
#6354
  - Because the `iota-sdk-types` does not exit, use `iota-sdk2` instead
  - Remove stable/unstable description in openapi.json from #6922

## Links to any relevant issues

Part of #3990 

## Type of change

- Enhancement (a non-breaking change which adds functionality)

---------

Co-authored-by: jkrvivian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Issues related to our CI pipeline sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team

Projects

None yet

10 participants