upstream(node): Introduce the concept of stable and unstable apis #6922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
bingyanglin
changed the title
piotrm50
approved these changes
May 22, 2025
muXxer
force-pushed
the
core-node/upstream-changes/mainnet-1.35.4-1.36.2
branch
from
0ff682a to
0925b9e
Compare
muXxer
force-pushed
the
node/upstream-1.35.4-1.36.2/19701
branch
from
22450eb to
8b93e68
Compare
muXxer
force-pushed
the
core-node/upstream-changes/mainnet-1.35.4-1.36.2
branch
from
0925b9e to
16e85d0
Compare
muXxer
force-pushed
the
node/upstream-1.35.4-1.36.2/19701
branch
from
8b93e68 to
051c3e8
Compare
jkrvivian
requested changes
Jun 5, 2025
jkrvivian
approved these changes
Jun 5, 2025
polinikita
approved these changes
Jun 5, 2025
sergiupopescu199
approved these changes
Jun 5, 2025
jkrvivian
merged commit 038571d
into
core-node/upstream-changes/mainnet-1.35.4-1.36.2
34 of 36 checks passed
muXxer
pushed a commit
that referenced
this pull request
Jun 10, 2025
#6929) # Description of change - Upstream range: [v1.35.4, v1.36.2) - Port the following Sui's commits which are contained in the single PR MystenLabs/sui#19029 - MystenLabs/sui@bf9ac99 - MystenLabs/sui@ea27dff - MystenLabs/sui@066a6b6 - Descriptions from commits - transaction-executor: add simulate_transaction trait method - rest: introduce transaction simulation endpoint - rest: introduce transaction resolve endpoint - Notes - The extra field `trace_builder_opt` of `execute_transaction_to_effects` was introduced in #6354 - Because the `iota-sdk-types` does not exit, use `iota-sdk2` instead - Remove stable/unstable description in openapi.json from #6922 ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) --------- Co-authored-by: jkrvivian <[email protected]>
muXxer
pushed a commit
that referenced
this pull request
Jun 10, 2025
) # Description of change - Upstream range: [v1.35.4, v1.36.2) - Port the following Sui's commits which are contained in the single PR MystenLabs/sui#19701 - MystenLabs/sui@512a4e0 - MystenLabs/sui@7d05486 - MystenLabs/sui@ea81ea5 - MystenLabs/sui@591f96c - MystenLabs/sui@13c1ec7 - MystenLabs/sui@3b665eb - Descriptions from commits - Enable marking APIs as either stable or unstable. By default unstable APIs are disabled and not served but the `enable_unstable_apis` can be set to `true` in order to enable serving of unstable APIs. - Stabalize the get and list checkpoints apis as well as introduce a new list full checkpoints api. - Until the rest service as a whole is "stabalized" with a sane set of default stable apis, have the default be to enable all unstable apis. - Notes - The `enable_experimental_rest_api` was renamed to be `enable_rest_api` in #3740 - The `worker_public_key` was renamed to be `protocol_public_key` in #3151 - Because the `iota-sdk-types` does not exit, remain original `iota-sdk2` instead - The `proc-macro2` version is updated in the upstream change, hence here we update it to be the latest version accordingly. (see https://crates.io/crates/proc-macro2) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` --------- Co-authored-by: jkrvivian <[email protected]>
muXxer
pushed a commit
that referenced
this pull request
Jun 10, 2025
#6929) # Description of change - Upstream range: [v1.35.4, v1.36.2) - Port the following Sui's commits which are contained in the single PR MystenLabs/sui#19029 - MystenLabs/sui@bf9ac99 - MystenLabs/sui@ea27dff - MystenLabs/sui@066a6b6 - Descriptions from commits - transaction-executor: add simulate_transaction trait method - rest: introduce transaction simulation endpoint - rest: introduce transaction resolve endpoint - Notes - The extra field `trace_builder_opt` of `execute_transaction_to_effects` was introduced in #6354 - Because the `iota-sdk-types` does not exit, use `iota-sdk2` instead - Remove stable/unstable description in openapi.json from #6922 ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) --------- Co-authored-by: jkrvivian <[email protected]>
10 tasks
muXxer
added a commit
that referenced
this pull request
Jun 10, 2025
…ainnet-1.35.4 to mainnet-1.36.2 (#7227) # Description of change This PR contains a batch of node-team related upstream changes. The changes have been individually reviewed before squash-merging. None of them modify protocol parameters, so a new protocol version is not necessary. This PR should be rebased on top of develop without squashing as it already contains squashed PRs. ## Links to any relevant issues List of included PRs: - #6923 - #6921 - #6932 - #6934 - #7228 - #6922 - #6929 List of included upstream commits: - MystenLabs/sui@b751830 - MystenLabs/sui@60867d4 - MystenLabs/sui@8be878a - MystenLabs/sui@e920c3e - MystenLabs/sui@c3562a3 - MystenLabs/sui@512a4e0 - MystenLabs/sui@7d05486 - MystenLabs/sui@ea81ea5 - MystenLabs/sui@591f96c - MystenLabs/sui@13c1ec7 - MystenLabs/sui@3b665eb - MystenLabs/sui@bf9ac99 - MystenLabs/sui@ea27dff - MystenLabs/sui@066a6b6 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) ### Release Notes - [ ] Protocol: - [x] Nodes (Validators and Full nodes): - rocksdb: enable `Lz4` compression even on level 1 - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
filipdulic
pushed a commit
that referenced
this pull request
Jul 16, 2025
) # Description of change - Upstream range: [v1.35.4, v1.36.2) - Port the following Sui's commits which are contained in the single PR MystenLabs/sui#19701 - MystenLabs/sui@512a4e0 - MystenLabs/sui@7d05486 - MystenLabs/sui@ea81ea5 - MystenLabs/sui@591f96c - MystenLabs/sui@13c1ec7 - MystenLabs/sui@3b665eb - Descriptions from commits - Enable marking APIs as either stable or unstable. By default unstable APIs are disabled and not served but the `enable_unstable_apis` can be set to `true` in order to enable serving of unstable APIs. - Stabalize the get and list checkpoints apis as well as introduce a new list full checkpoints api. - Until the rest service as a whole is "stabalized" with a sane set of default stable apis, have the default be to enable all unstable apis. - Notes - The `enable_experimental_rest_api` was renamed to be `enable_rest_api` in #3740 - The `worker_public_key` was renamed to be `protocol_public_key` in #3151 - Because the `iota-sdk-types` does not exit, remain original `iota-sdk2` instead - The `proc-macro2` version is updated in the upstream change, hence here we update it to be the latest version accordingly. (see https://crates.io/crates/proc-macro2) ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) ## How the change has been tested Ran the local network with `RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet` --------- Co-authored-by: jkrvivian <[email protected]>
filipdulic
pushed a commit
that referenced
this pull request
Jul 16, 2025
#6929) # Description of change - Upstream range: [v1.35.4, v1.36.2) - Port the following Sui's commits which are contained in the single PR MystenLabs/sui#19029 - MystenLabs/sui@bf9ac99 - MystenLabs/sui@ea27dff - MystenLabs/sui@066a6b6 - Descriptions from commits - transaction-executor: add simulate_transaction trait method - rest: introduce transaction simulation endpoint - rest: introduce transaction resolve endpoint - Notes - The extra field `trace_builder_opt` of `execute_transaction_to_effects` was introduced in #6354 - Because the `iota-sdk-types` does not exit, use `iota-sdk2` instead - Remove stable/unstable description in openapi.json from #6922 ## Links to any relevant issues Part of #3990 ## Type of change - Enhancement (a non-breaking change which adds functionality) --------- Co-authored-by: jkrvivian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
enable_unstable_apiscan be set totruein order to enable serving of unstable APIs.enable_experimental_rest_apiwas renamed to beenable_rest_apiin fix(rest-api): Move/restand/v2endpoints to/api/v1#3740worker_public_keywas renamed to beprotocol_public_keyin chore(core-node)!: Cleanup Narwhal related fields in IOTA Framework codebase (Move and Rust) #3151iota-sdk-typesdoes not exit, remain originaliota-sdk2insteadproc-macro2version is updated in the upstream change, hence here we update it to be the latest version accordingly. (see https://crates.io/crates/proc-macro2)Links to any relevant issues
Part of #3990
Type of change
How the change has been tested
Ran the local network with
RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet