Port upstream node team related changes [mainnet-v1.32.2..mainnet-v1.36.2)

[muXxer]

• Ask other teams how they created the report (format, where etc).
• Ask other teams how they track upstream changes (how do they mark critical ones etc)
• We should remember the latest hash of the commits we checked, so we don't redo the same work
• Does it make sense to use the slipstream script?

mainnet-v1.32.2 to mainnet-v1.36.2

Upstream change details: here

Commits to track from mainnet-v1.32.2 to mainnet-v1.36.2

• (🚧 Bing) Check changes in upstream crates/sui-protocol-config (18)
• (🚧 Bing) Check changes in upstream crates/sui-rest-api (8)
• (🚧 Vivian) Check changes in upstream crates/sui-snapshot (1)
• (🚧 Vivian) Check changes in upstream crates/sui-config (22)
• (🚧 Vivian) Check changes in upstream crates/sui-archival (1)
• (🚧 Vivian) Check changes in upstream crates/sui-authority-aggregation (2)
• (🚧 Vivian) Check changes in upstream docker (5)
• (🚧 Gokhan) Check changes in upstream crates/sui-node (7)
• (🚧 Gokhan) Check changes in upstream crates/sui-network (2)
• (🚧 Bing) Check changes in upstream crates/sui-core (66)
• (🚧 Vivian) Check changes in upstream crates/sui-types (19)
• (🚧 Vivian) cross crates commit (52)

[bingyanglin]

The following is the flow provided by @thibault-martinez 🙏

• Get the list of commits for the crates between two dates. An example to find all the commits of November in 5 different crates:
  git log --since="2024-11-01" --until="2024-11-31" --format="format:https://github.com/MystenLabs/sui/commit/%H" -- crates/sui crates/sui-open-rpc crates/sui-open-rpc-macros crates/sui-sdk crates/sui-transaction-builder. Note that this needs to be done in the SUI repo because the goal is to identify SUI's patches.
• Manually analyze all the commits, identify the interested ones, collect them and put them in a document like this one.
• Discuss them with the team and decide whether to port them or not.
• Finally, select those to be ported and put them in this doc.

The following is the flow @kodemartin currently does 🙏

• About the report: Here is the confluence page we update for the first iteration.

Method

1. Cloned sui repository locally

2. git checkout mainnet-v1.36.2 (you can choose a later release if you want)

3. git log --reverse --patch mainnet-v1.32.2.. crates/{iota-indexer,iota-graphql-rpc*,....} (obviously you replace with the libraries you wan to track

4. Go over each commit and tried to classify it, label it, and group it if possible

   4a. Classification:

   • Candidates: Commits that are really no-brainers (fixes, straight-forwards refactorings or optimazations) and seem like good candidates to integrate.
   • Questionable: Patches that need further discussion with all the stakeholders (e.g. breaking changes, deprecations, major features)

   4b. Labeling: Add a tentative label for each commit or group of commits like so: {"side-effects": "minor|medium|major", "type": "fix|refactoring|feature|improvement|etc", "comment": }. This is of course very subjective, and intends in helping with prioritizing/triaging candidate commits in the next steps.

This allows triaging/prioritizing within the team as a next step for Candidates, and organizing calls with stakeholders for Questionables.