Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Update node-sass dependency #1435

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Update node-sass dependency #1435

merged 1 commit into from
Jun 11, 2018

Conversation

Fabious
Copy link
Contributor

@Fabious Fabious commented May 17, 2018

Short description of what this resolves:

"ionic start" build fail with node 10 on windows

Changes proposed in this pull request:

  • Updated node-sass dependency from 4.7.2 to 4.9.0

Fixes: #

Updating node-sass dependency from 4.7.2 to 4.9.0 to make it works with node 10 on windows (build fail with ionic start)
@habaansou
Copy link

Bonsoir les amis après beaucoup de temps de recherche voila la réponse avertissement parti : npm i -D -E [email protected]

@Asone
Copy link

Asone commented Jun 9, 2018

I do agree with the package upgrade and PR as it brings support for linux_musl-x64-64 node binding ( See here ) which is used by circleci node:alpine docker image.

4.7.2 leads to 404 HTTP on install in circle-ci as it fetches an non existent binding using node:alpine docker image.

Here's an example of what i currently get for a project of mine : my circle-ci build

@imhoffd imhoffd merged commit 89ce9a5 into ionic-team:master Jun 11, 2018
@imhoffd
Copy link
Contributor

imhoffd commented Jun 11, 2018

Thanks @Fabious!

@imhoffd
Copy link
Contributor

imhoffd commented Jun 11, 2018

3.1.10 is out

@habaansou
Copy link

habaansou commented Jul 4, 2018 via email

trsrm added a commit to powwowinc/ionic-app-scripts-tiny that referenced this pull request Jan 2, 2019
3.1.9:
* fix(2889): fix build error with --prod
* fix(serve): start listening when watch is ready
* fix(live-server): update android platform path (ionic-team#1407)
* docs(changelog): 3.1.9

3.1.10:
* Update node-sass dependency (ionic-team#1435)
Updating node-sass dependency from 4.7.2 to 4.9.0 to make it works with node 10 on windows (build fail with ionic start)
* chore(package): bump deps (ionic-team#1421)
* chore(deps): no package lock
* chore(changelog): 3.1.10

3.1.11:
* fix(serve): fix EADDRINUSE issue with dev logger server
fixes ionic-team/ionic-cli#3368
fixes ionic-team/ionic-cli#1678
fixes ionic-team/ionic-cli#1830
fixes ionic-team/ionic-cli#1721
fixes ionic-team/ionic-cli#1866
fixes ionic-team/ionic-cli#1808
fixes ionic-team/ionic-cli#3022
* docs(changelog): 3.1.11 changes

3.2.0:
* feat(environments): configuration via process.env.VAR replacement (ionic-team#1471)
* fix(sass): remove PostCSS warning (ionic-team#1364)
This removes following warning:
Remove warning: Without `from` option PostCSS could generate wrong source map or do not find Browserslist config. Set it to CSS file path or to `undefined` to prevent this warning
`from: the input file name (most runners set it automatically).`
Source: https://github.com/postcss/postcss
Fixes ionic-team#1359 #13763
ionic-team#1359
ionic-team/ionic-framework#13763
* fix(serve): use wss protocol for secure websocket when page is using https (ionic-team#1358)
* docs(changelog): 3.2.0

3.2.1:
* docs(readme): add note about existing declaration
addresses ionic-team/ionic-cli#3541
* chore(deps): update webpack to 3.12.0 (ionic-team#1477)
* chore(deps): bump node-sass to 4.9.3 to fix security warnings (ionic-team#1483)
* chore(deps): bump node-sass to 4.10.0 to fix security warnings (ionic-team#1493)
* docs(changelog): 3.2.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants