-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostCSS could generate wrong source map error #13763
Comments
This removes following warning: Remove warning: Without `from` option PostCSS could generate wrong source map or do not find Browserslist config. Set it to CSS file path or to `undefined` to prevent this warning `from: the input file name (most runners set it automatically).` Source: https://github.com/postcss/postcss Fixes ionic-team#1359 #13763 ionic-team#1359 ionic-team/ionic-framework#13763
As the warning says:
I added the field This resolves this warning. But I don't know if this has further consequences and the Ionic Team needs to fill in there a path to the generated css file or something like that. @danbucholtz Could you review this please? Our automated builds are failing because of this. Edit: PostCSS uses ultimately console.warn, but this goes on node to the stderr pipe and our TeamFS fails.
|
Until this is fixed, one possibility is to revert back some patches before the error was introduced:
https://github.com/postcss/postcss/blame/master/lib/lazy-result.es6#L192 In the: package.json of ionic-app-scripts |
was this fixed? |
@thezakman Not yet. The issue is open. The warning still exists. |
find sass.js file. under /node_modules/@ionic/app-scripts/dist/sass.js. Finally should be like this: |
ionic-team/ionic-app-scripts#1364 (comment)
Please use the suggestion above for now. |
i solve problem using this ( thanx also to @AlbenJohn) |
Any fix on this? |
While it is not breaking my builds, this warning appears for me as well. This is a one line quick fix, is there already a pull request for this? |
@johnroper100 Yes and it was approved (it's linked above). Edit: The map files are working correctly. |
This warning still apears. |
1 similar comment
This warning still apears. |
This warning still appears. |
@JosepAlacid @Veyhunk @ajmalhassan try using the fix that @hanifmazlan suggested. It actually works for me. https://stackoverflow.com/a/48315414/3288671 |
True, it does, but as @StefanRein suggests, it's still miles away from any production-like environment. better to avoid node_modules. Still waiting for a proper fix. Any updates from the Ionic Team? |
This warning still apears. |
4 similar comments
This warning still apears. |
This warning still apears. |
This warning still apears. |
This warning still apears. |
Please stop. This is not helping in any way. Though I don't want to speak on behalf of the IONIC team, I feel like something needs to be said here: This issue doesn't get closer to resolution in proportion to the number of comments that say "This warning still appears." / "Any update on this" / "Any fix for this" / etc. If you're stuck, read the thread – there's a workaround, which as the name suggests, will get you working. If you'd like to get updates on this, save some keystrokes by clicking the 'Subscribe' button – that allows you to receive updates in your e-mail. You'll also receive updates every time someone comments "Any update on this?", so please, don't be that person. |
This warning still apears. |
@jhonnhenry dude, seriously? We know - the issue is still open. Just subscribe and be on your way... If you insist on leaving a comment, help us be more productive by providing some insight like what versions you're running. |
I found this Workaround First find sass.js file under /node_modules/@ionic/app-scripts/dist/sass.js. inside search var postcssOptions and add from: undefined, Finally should be like this: var postcssOptions = { |
This removes following warning: Remove warning: Without `from` option PostCSS could generate wrong source map or do not find Browserslist config. Set it to CSS file path or to `undefined` to prevent this warning `from: the input file name (most runners set it automatically).` Source: https://github.com/postcss/postcss Fixes #1359 #13763 #1359 ionic-team/ionic-framework#13763
Still got his warning. Jumping into node_modules is no serious ::/ |
Thanks for the issue! We have moved the source code and issues for Ionic 3 into a separate repository. I am moving this issue to the repository for Ionic 3. Please track this issue over there. Thank you for using Ionic! |
Issue moved to: ionic-team/ionic-v3#883 |
Ionic version: (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
If we build a new app using your blank starter or any other template building the android app we are running into this error
Expected behavior:
The bug message should not be
Steps to reproduce:
Create a new blank app using
ionic start postcss
build the android app doing
ionic cordova build android
and you can see log with the warn or error message
Ionic info: (run
ionic info
from a terminal/cmd prompt and paste output below):The text was updated successfully, but these errors were encountered: