[SYCL][NFC] Refactor plugin CMakeLists.txt#5799
Merged
bader merged 7 commits intointel:syclfrom Apr 1, 2022
Merged
Conversation
bader
reviewed
Mar 30, 2022
bader
previously approved these changes
Mar 30, 2022
npmiller
previously approved these changes
Mar 30, 2022
bader
reviewed
Mar 30, 2022
pvchupin
previously approved these changes
Mar 30, 2022
bader
approved these changes
Mar 31, 2022
npmiller
approved these changes
Mar 31, 2022
jchlanda
approved these changes
Mar 31, 2022
steffenlarsen
approved these changes
Mar 31, 2022
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
Very nice refactor! 👍
Contributor
Author
|
@intel/dpcpp-l0-pi-reviewers ping |
smaslov-intel
approved these changes
Apr 1, 2022
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 2, 2022
* sycl: (3343 commits) [SYCL][L0] Disable round-robin submissions to multiple CCSs (intel#5945) [SYCL][CUDA] Don't link pi_cuda against libsycl (intel#5908) [CI] Disable -Werror by default (intel#5889) [BuildBot] Uplift CPU/FPGAEMU RT version to 2022.13.3.0.16 (intel#5883) [SYCL][CUDA][libclc] Add support for atomic fp exchange and compare exchange (intel#5937) [SYCL] Fix device code outlining for static local variables (intel#5915) [SYCL][NFC] Refactor plugin CMakeLists.txt (intel#5799) [SPIR-V][Doc] Add JointMatrixWorkItemLengthINTEL instruction to joint matrix extension (intel#5781) [SYCL] Expand device_global map and make initialization order agnostic (intel#5902) [SYCL][CUDA] Add IPSCCP pass to O0 by default (intel#5900) [ESIMD] Disable ABI changes warnings in host compiler. (intel#5931) [SYCL] Make properties constructor constexpr (intel#5928) [NFC][SYCL] Fix static analysis warning (intel#5933) [CODEOWNERS][NFC] Assign code owners for CI scripts (intel#5873) [SYCL] Store the kernel object size in the integration header (intel#5862) [SYCL][ESIMD] Change esimd-verifier logic for detecting valid SYCL calls (intel#5914) [SYCL][CUDA][DOC] GettingStartedGuide.md to recommend cuda 11.6 (intel#5917) [SYCL][L0] Move command list cache usage under mutex (intel#5874) [SYCL][FPGA] Prepare future implementation of experimental pipe properties (intel#5886) [CI] Roll back intel driver to the latest version (intel#5925) ...
| set(SYCL_BUILD_PI_HIP ON) | ||
| endif() | ||
| if ("esimd_emulator" IN_LIST SYCL_ENABLE_PLUGINS) | ||
| set(SYCL_BUILD_PI_HIP ON) |
Contributor
There was a problem hiding this comment.
@dongkyunahn-intel, yes, I think so. Looks like that.
Contributor
There was a problem hiding this comment.
Should be SYCL_BUILD_PI_ESIMD_EMULATOR
Contributor
There was a problem hiding this comment.
Thanks for catching that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate code and allow build and install plugins separately.